[IMP] estate: corretions after code review

tskv · tskv · commit 013523366118 · 2025-11-24T14:24:38.000+01:00
diff --git a/awesome_owl/__manifest__.py b/awesome_owl/__manifest__.py
@@ -32,6 +32,7 @@
             ('include', 'web._assets_backend_helpers'),
             'web/static/src/scss/pre_variables.scss',
             'web/static/lib/bootstrap/scss/_variables.scss',
+            'web/static/lib/bootstrap/scss/_maps.scss',
             ('include', 'web._assets_bootstrap'),
             ('include', 'web._assets_core'),
             'web/static/src/libs/fontawesome/css/font-awesome.css',
diff --git a/awesome_owl/static/src/counter/counter.js b/awesome_owl/static/src/counter/counter.js
@@ -2,13 +2,19 @@ import { useState, Component } from "@odoo/owl";
 
 export class Counter extends Component {
     static template = "awesome_owl.Counter";
+    static props = {
+        onChange: { type: Function, optional: true }
+    }
 
     setup() {
         this.state = useState({ value: 0 });
     }
 
     increment() {
         this.state.value++;
+        if (this.props.onChange) {
+            this.props.onChange();
+        }
     }
 
 }
diff --git a/awesome_owl/static/src/playground.js b/awesome_owl/static/src/playground.js
@@ -1,15 +1,20 @@
 import { Component, useState, markup } from "@odoo/owl";
 import { Counter } from "./counter/counter"
 import { Card } from "./card/card";
+import { TodoList } from "./todo_list/todo_list";
 
 export class Playground extends Component {
     static template = "awesome_owl.Playground";
-    static components = { Counter, Card };
-
-    value1 = "<div class='text-primary'>test</div>";
-    value2 = markup("<a href='odoo.com'>test2</a>");
+    static components = { Counter, Card, TodoList };
 
     setup() {
+        this.value1 = "<div class='text-primary'>test</div>";
+        this.value2 = markup("<a href='odoo.com'>test2</a>");
+        this.state = useState({ sum : 0 });
+    }
+
+    implementSum() {
+        this.state.sum++;
     }
 
 }
diff --git a/awesome_owl/static/src/playground.xml b/awesome_owl/static/src/playground.xml
@@ -6,13 +6,20 @@
             hello world
         </div>
         <div>
-            <Counter/>
-            <Counter/>
+            <Counter onChange.bind="implementSum"/>
+            <Counter onChange.bind="implementSum"/>
         </div>
         <div>
             <Card title="'card 1'" content="value1"/>
             <Card title="'card 2'" content="value2"/>
         </div>
+        <div>
+            The sum is: <t t-esc="state.sum"/>
+        </div>
+        <p></p>
+        <div>
+            <TodoList/>
+        </div>
     </t>
 
 </templates>
diff --git a/awesome_owl/static/src/todo_list/todo_item.js b/awesome_owl/static/src/todo_list/todo_item.js
@@ -0,0 +1,14 @@
+import { Component, useState } from "@odoo/owl"
+
+export class TodoItem extends Component {
+    static template = "awesome_owl.TodoItem";
+    static props = {
+        todo : {
+            type: Object,
+            shape: {
+                id: Number,
+                description: String,
+                isCompleted: Boolean }
+        }
+    }
+}
diff --git a/awesome_owl/static/src/todo_list/todo_item.xml b/awesome_owl/static/src/todo_list/todo_item.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<templates xml:space="preserve">
+
+    <t t-name="awesome_owl.TodoItem">
+        <div>
+            <p>Id: <t t-esc="todo.id"/></p>
+            <p>Description: <t t-esc="todo.description"/></p>
+        </div>
+    </t>
+
+</templates>
diff --git a/awesome_owl/static/src/todo_list/todo_list.js b/awesome_owl/static/src/todo_list/todo_list.js
@@ -0,0 +1,15 @@
+import { Component, useState } from "@odoo/owl"
+import { TodoItem } from "./todo_item"
+
+export class TodoList extends Component {
+    static template = "awesome_owl.TodoList";
+    static components = { TodoItem };
+
+    setup() {
+        this.todos = useState([
+            { id:1, description: "buy bread", isCompleted: false },
+            { id:2, description: "buy milk", isCompleted: false },
+        ])
+    }
+}
+
diff --git a/awesome_owl/static/src/todo_list/todo_list.xml b/awesome_owl/static/src/todo_list/todo_list.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<templates xml:space="preserve">
+
+    <t t-name="awesome_owl.TodoList">
+        <p>Todo List:</p>
+        <t t-foreach="todos" t-as="todo" t-key="todo.id">
+            <p><t t-esc="todo.id"/>. <t t-esc="todo.description"/></p>
+        </t>
+    </t>
+
+</templates>
diff --git a/estate/__init__.py b/estate/__init__.py
@@ -1,3 +1 @@
-# Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from . import models
diff --git a/estate/__manifest__.py b/estate/__manifest__.py
@@ -16,8 +16,6 @@
         'views/estate_menus.xml',
         'views/res_users_views.xml',
     ],
-    'demo': [
-    ],
     'installable': True,
     'application': True,
     'license': 'LGPL-3',
diff --git a/estate/models/__init__.py b/estate/models/__init__.py
@@ -1,7 +1,5 @@
-# Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from . import estate_property
-from . import estate_property_type
-from . import estate_property_tag
 from . import estate_property_offer
+from . import estate_property_tag
+from . import estate_property_type
 from . import res_users
diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py
@@ -22,19 +22,28 @@ class EstateProperty(models.Model):
     garage = fields.Boolean('Garage')
     garden = fields.Boolean('Garden')
     garden_area = fields.Integer('Garden Area (sqm)')
-    garden_orientation = fields.Selection(string='Garden orientation',
-                                          selection=[('north', 'North'),
-                                                    ('south', 'South'),
-                                                    ('east', 'East'),
-                                                    ('west', 'West')]
-                                          )
-    state = fields.Selection(string='State',
-                            selection=[('new', 'New'),
-                                    ('offer_received', 'Offer Received'),
-                                    ('offer_accepted', 'Offer Accepted'),
-                                    ('sold', 'Sold'),
-                                    ('cancelled', 'Cancelled')],
-                             default='new', required=True, copy=False)
+    garden_orientation = fields.Selection(
+            string='Garden orientation',
+            selection=[
+                ('north', 'North'),
+                ('south', 'South'),
+                ('east', 'East'),
+                ('west', 'West'),
+            ],
+        )
+    state = fields.Selection(
+        string='State',
+        selection=[
+            ('new', 'New'),
+            ('offer_received', 'Offer Received'),
+            ('offer_accepted', 'Offer Accepted'),
+            ('sold', 'Sold'),
+            ('cancelled', 'Cancelled'),
+        ],
+        default='new',
+        required=True,
+        copy=False,
+    )
     property_type_id = fields.Many2one('estate.property.type', string='Property Type')
     property_tag_ids = fields.Many2many('estate.property.tag', string='Property Tag')
     buyer_id = fields.Many2one('res.partner', string='Buyer', copy=False,
@@ -63,10 +72,7 @@ def _compute_total_area(self):
     @api.depends('offer_ids.price')
     def _compute_best_offer(self):
         for record in self:
-            if record.offer_ids:
-                record.best_offer = max(record.offer_ids.mapped('price'))
-            else:
-                record.best_offer = 0
+            record.best_offer = max(record.offer_ids.mapped('price'), default=0.0)
 
     @api.constrains('selling_price', 'expected_price')
     def _check_selling_price(self):
diff --git a/estate/models/estate_property_offer.py b/estate/models/estate_property_offer.py
@@ -1,6 +1,6 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
-from odoo import fields, models, api, exceptions
+from odoo import fields, models, api, exceptions, _
 from datetime import date, timedelta
 
 
@@ -10,8 +10,11 @@ class EstatePropertyOffer(models.Model):
     _order = "price desc"
 
     price = fields.Float(string='Price')
-    status = fields.Selection(string='Status', copy=False,
-                            selection=[('accepted', 'Accepted'), ('refused', 'Refused')])
+    status = fields.Selection(
+        string='Status',
+        copy=False,
+        selection=[('accepted', 'Accepted'), ('refused', 'Refused')]
+    )
     partner_id = fields.Many2one('res.partner', string='Customer', required=True)
     property_id = fields.Many2one('estate.property', string='Property', required=True)
     validity = fields.Integer(string='Validity (days)', default=7)
@@ -32,13 +35,13 @@ def _inverse_deadline(self):
         for record in self:
             record.validity = (record.date_deadline - (record.create_date.date() if record.create_date else date.today())).days
 
-    @api.model
+    @api.model_create_multi
     def create(self, vals_list):
         for vals in vals_list:
-            if 'property_id' in vals and vals.get('property_id'):
+            if vals.get('property_id'):
                 current_property = self.env['estate.property'].browse(vals['property_id'])
-                if 'price' in vals and current_property.best_offer > vals.get('price', 0):
-                    raise exceptions.ValidationError(f'The offer must be higher than {current_property.best_offer}')
+                if current_property.best_offer > vals.get('price', 0):
+                    raise exceptions.ValidationError(_("The offer must be higher than %(best_offer)s", best_offer=current_property.best_offer))
                 if current_property.state == 'new':
                     current_property.state = 'offer_received'
         return super().create(vals_list)
diff --git a/estate/models/estate_property_tag.py b/estate/models/estate_property_tag.py
@@ -1,12 +1,10 @@
-# Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from odoo import fields, models
 
 
 class EstatePropertyTag(models.Model):
     _name = 'estate.property.tag'
-    _description = 'Estate Property Tag'
-    _order = "name"
+    _description = "Estate Property Tag"
+    _order = 'name'
 
     name = fields.Char(string='Property Tag', required=True)
     color = fields.Integer()
diff --git a/estate/models/estate_property_type.py b/estate/models/estate_property_type.py
@@ -1,5 +1,3 @@
-# Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from odoo import fields, models, api
 
 
diff --git a/estate/models/res_users.py b/estate/models/res_users.py
@@ -1,5 +1,3 @@
-# Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from odoo import fields, models
 
 
diff --git a/estate/views/estate_property_offer_views.xml b/estate/views/estate_property_offer_views.xml
@@ -43,7 +43,7 @@
             <field name="name">Offers</field>
             <field name="res_model">estate.property.offer</field>
             <field name="view_mode">list,form</field>
-            <field name="domain">[('property_type_id','=',active_id)]</field>
+            <field name="domain">[('property_type_id', '=', active_id)]</field>
     </record>
 
 </odoo>
diff --git a/estate/views/estate_property_views.xml b/estate/views/estate_property_views.xml
@@ -142,7 +142,7 @@
         <field name="res_model">estate.property</field>
         <field name="view_mode">list,form,kanban</field>
         <field name="search_view_id" ref="estate_property_view_search"/>
-        <field name="context">{'search_default_filter_available':1}</field>
+        <field name="context">{'search_default_filter_available': 1}</field>
     </record>
 
 </odoo>
diff --git a/estate_account/__init__.py b/estate_account/__init__.py
@@ -1,3 +1 @@
-# Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from . import models
diff --git a/estate_account/__manifest__.py b/estate_account/__manifest__.py
@@ -8,10 +8,6 @@
     'description': """
     Tutorial Project
     """,
-    'data': [
-    ],
-    'demo': [
-    ],
     'installable': True,
     'application': True,
     'license': 'LGPL-3',
diff --git a/estate_account/models/__init__.py b/estate_account/models/__init__.py
@@ -1,3 +1 @@
-# Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from . import estate_property
diff --git a/estate_account/models/estate_property.py b/estate_account/models/estate_property.py
@@ -1,23 +1,19 @@
-# Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from odoo import models, Command
 
 
 class EstateProperty(models.Model):
     _inherit = 'estate.property'
 
     def action_property_sold(self):
-        invoice_vals_list = []
-        for record in self:
-            if record.state == 'offer_accepted' and record.buyer_id:
-                invoice_vals = {
+        if self.state == 'offer_accepted' and self.buyer_id:
+            invoice_vals = {
                     'move_type': 'out_invoice',
-                    'partner_id': record.buyer_id.id,
+                    'partner_id': self.buyer_id.id,
                     'invoice_line_ids': [
                         Command.create({
                             "name": "Commission 6%",
                             "quantity": 1,
-                            "price_unit": record.selling_price * 0.06,
+                            "price_unit": self.selling_price * 0.06,
                         }),
                         Command.create({
                             "name": "Administrative fees",
@@ -26,6 +22,5 @@ def action_property_sold(self):
                         }),
                     ],
                 }
-                invoice_vals_list.append(invoice_vals)
-        self.env['account.move'].sudo().create(invoice_vals_list)
+            self.env['account.move'].sudo().create(invoice_vals)
         return super().action_property_sold()

Original file line number	Diff line number	Diff line change
`@@ -2,13 +2,19 @@ import { useState, Component } from "@odoo/owl";`
`2`	`2`
`3`	`3`	`export class Counter extends Component {`
`4`	`4`	`static template = "awesome_owl.Counter";`
	`5`	`+ static props = {`
	`6`	`+ onChange: { type: Function, optional: true }`
	`7`	`+ }`
`5`	`8`
`6`	`9`	`setup() {`
`7`	`10`	`this.state = useState({ value: 0 });`
`8`	`11`	`}`
`9`	`12`
`10`	`13`	`increment() {`
`11`	`14`	`this.state.value++;`
	`15`	`+ if (this.props.onChange) {`
	`16`	`+ this.props.onChange();`
	`17`	`+ }`
`12`	`18`	`}`
`13`	`19`
`14`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1 @@`
`1`		`-# Part of Odoo. See LICENSE file for full copyright and licensing details.`
`2`		`-`
`3`	`1`	`from . import models`