Migrate from Lwt_logs to Logs using ciao_lwt #695
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
reviewed
Nov 24, 2025
| (* Lwt_log_core.add_rule "os*" Lwt_log_js.Debug; *) | ||
| Lwt_log_core.add_rule "%%%MODULE_NAME%%%*" Lwt_log_js.Debug | ||
| (* Lwt_log_core.add_rule "*" Lwt_log_js.Debug *) | ||
| Logs.set_level (Some Logs.Debug) |
Contributor
There was a problem hiding this comment.
This is not equivalent. Before it was setting a rule for %%%MODULE_NAME%%%*, which either meant nothing or changed the level of some of the user's sources. Now it sets the log level for all the sources, including the ones in Eliom.
Perhaps we should create the log source mentioned in the comment above ? Or perhaps the new behavior is fine considering it's the result of adding <debugmode/> to the config ?
Member
Author
There was a problem hiding this comment.
Yes I think it's ok to set the log level for everything when debugmode is true.
This is in the template anyway. The purpose of this code was mainly to give examples in comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.