Repository navigation
Commit d90657b
docs(spec): the TranslationDataSchema comment counts sixteen per-app groups, not fifteen (#27033)
Follow-up of #26170
## What changes
One word in a TSDoc comment.
`packages/spec/src/system/translation.zod.ts`, on
`TranslationDataSchema`, said "Fifteen groups: every group the platform
bundle declares EXCEPT `settings`". It now says "Sixteen groups".
## Why
The round-4 contract review on #26831 (comment 6458660736) found this
one stale count. When #26831 merged main's `books` group (#26819), both
parents had made the same Fourteen to Fifteen edit on this line, so git
kept it without a conflict, and the hand pass that moved the other
spelled counts did not reach it. At this head
`appTranslationDataShape()` has sixteen keys, and the same comment block
already calls the platform face "the seventeen-group face".
The line is a code comment only. It is not a `describe`, a refusal
message, the JSON Schema or a generated doc, and no gate reads it.
## Verification
- `git diff origin/main` is one line in `translation.zod.ts` plus the
patch changeset. `check-changeset-no-major` and `check-empty-changeset`
pass locally.
- `appTranslationDataShape()` at this head lists sixteen keys: objects,
picklists, apps, messages, globalActions, dashboards, datasets, reports,
pages, flows, hooks, positions, permissions, books, metadataForms,
settingsCommon.
- The pre-push hook `check:commit-card-trailers` passed.
Clause-②: no
Metadata-protocol: none
Skills-docs: none, because no `skills/**` file states the per-app group
count.
## Human Minimum
- [x] 1. Schemas start as Zod; `packages/spec` holds no runtime logic.
- [x] 2. Every name I added uses the casing for its kind (no names
added).
- [x] 3. No formatter ran; `pnpm lint` is left to CI for a one-word
comment edit.
- [x] 4. One issue, one branch off an up-to-date `main`, one pull
request.
- [x] 5. A change that publishes carries a changeset, and both
declaration lines are filled in here and in the changeset
(`.changeset/26170-translation-data-comment-count.md`,
`@objectstack/spec` patch).
- [x] 6. `packages/spec` touched: its generated artifacts are
regenerated and committed (a comment moves no generated artifact).
- [x] 7. No hand edits to `content/docs/references/`,
`packages/*/CHANGELOG.md` or `content/docs/releases/`.
- [x] 8. Title, body and comments are in English.
- [x] The *Before Submitting* list in CONTRIBUTING.md is done.
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent d8a9cc5 commit d90657b
2 files changed
Lines changed: 11 additions & 1 deletion
File tree
- .changeset
- packages/spec/src/system
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2079 | 2079 | | |
2080 | 2080 | | |
2081 | 2081 | | |
2082 | | - | |
| 2082 | + | |
2083 | 2083 | | |
2084 | 2084 | | |
2085 | 2085 | | |
| |||
0 commit comments