Merge remote-tracking branch 'origin/main' into claude/issue-16233-agents-return-propagating-seams

Author: claude

.changeset/17508-repeater-row-property-localisation.md

@@ -0,0 +1,18 @@
+---
+'@objectstack/platform-objects': minor
+'@objectstack/spec': minor
+---
+
+Studio's property-panel repeater tables name their columns in the author's own language: every repeater enumerates its row properties in the owning `*.form.ts`, and all four platform catalogs carry a translated name for each one
+
+Clause-②: no
+
+A `type: 'repeater'` renders as a table whose column heads come from the form's declared row children when it declares any, and from the served JSON Schema `items.properties[k].title` when it does not. `os i18n extract` only emits a `metadataForms.<type>.fields['<path>.<prop>']` key for a **declared** child, so a repeater that enumerated none had no localisation channel at all — #17232 (PR #17500) authored English titles on thirteen item schemas, #17505 and #17506 on four more, and every one of those column heads reached a Chinese, Japanese or Spanish author in English.
+
+Both halves land together, because either alone is a half-state: 112 row properties across fifteen repeaters are now enumerated, each with a `label` equal to the item schema's own `.meta({ title })`, and the `en` / `zh-CN` / `ja-JP` / `es-ES` catalogs gain a leaf for each. Nothing in the accept set moves — the same author input parses identically before and after, and no row child declares a `type`, so the row widgets stay schema-derived.
+
+Terms reuse the word each catalog already uses for the concept (`Label` → 显示名称 / 表示名 / Etiqueta, `Filter` → 筛选 / フィルター / Filtro, `Timeout (ms)` → 超时（毫秒）/ タイムアウト（ms）/ Tiempo de espera (ms)), and `field.options.*` mirrors its `object.fields.options.*` twin verbatim.
+
+`page.variables.source` is the one existing string that moves. Its children were enumerated without labels, so the extractor emitted the humanized path `"Source"` as the English source and the bundle overlay then wrote that over the schema's authored `"Written By"`. The form now declares the label, the `en` leaf becomes `Written By`, and its three translations are re-authored with it (写入组件 / 書き込み元 / Escrito por).
+
+`view.columns` / `view.sort` / `view.tabs` are untitled and enumerate no children — they are #17507's, and are untouched here. `object.fields.options` stays the curated four-key subset its reconciliation-ledger entry declares.

.changeset/19064-translation-target-object-artifact-reach.md

@@ -0,0 +1,19 @@
+---
+"@objectstack/lint": patch
+---
+
+`translation-target-unknown` no longer reports the locale keys a package ships for an object a SIBLING package of the same artifact declares — the OBJECT rung's universe read `stack.objects` alone, while this rule's own docblock already declared the wider `artifactProvidedObjectNames` reach (#19064).
+
+`os build` runs the rule table per PACKAGE as well as over the union (`compile.ts` step 3b-ii): each package body is judged as its own stack with the artifact's `packages[]` beside it as resolution context (`packageBodyAsStack`, #16611). On that leg `stack.objects` holds ONE package's objects, so a bundle key naming a sibling's object resolved against nothing. Measured on the probe stack (`examples/app-multi-package`'s shape — `core` owns `crm_account`, `orders` reads it and here also translates it), the key produced one `error` at `translations[0]["zh-CN"].objects.crm_account`:
+
+> Translations are keyed to "crm_account", which no object in this stack defines. The resolver looks up keys derived from the metadata, so this whole subtree is dead weight — every label it carries renders untranslated.
+>
+> *Rename the key to the object it was written for, drop it, or ignore this if the object is contributed by another installed package. Defined objects: crm_order.*
+
+That is the remedy that deletes a translation the runtime resolves, at `error`, so the run FAILED on it — and it is byte-identical, but for the name, to the finding a genuine typo produces. ADR-0130 makes the release artifact the co-ownership boundary, so the miss is the RUN's blind spot and not the author's mistake.
+
+**The precedent is followed, not re-decided.** `validateObjectReferences` closed this exact shape on this exact carrier for object NAMES (#16611 — `artifactProvidedObjectNames` folded into its `resolvable` set). What differs here is the RETURN, and two pins hold it: this rule's universe is keyed by FACTS, not names, so the sibling's fields, options, views, sections and rules are folded WITH the name through the same collector the declaration loop uses. A name-only fold would resolve the object key and then judge the owner's own field keys against an empty fact set — the same false positive one level up — and a wholesale subtree skip (rung 2b's answer, for a target whose declaration is genuinely invisible) would leave the per-package leg unable to see a typo the union leg reports.
+
+**The control, which is what makes this a narrowing and not a hole.** Widening a universe trades a false positive for a blind spot unless every genuine orphan still reports, so both directions are pinned side by side: the same package judged ALONE still errors (the context is what does the work); a name no entry of the artifact declares is still an `error` with its rule id, and the remedy now enumerates what the artifact provides; a field the sibling does not declare is still an `error` under the now-resolved object; one bundle carrying both a sibling key and a typo reports exactly the typo; an entry with no readable body (a segment reference) makes nothing addressable; and the single-`defineStack` shape is untouched, because `objects` is a stack collection with no `stack.manifest` form to read.
+
+No schema moved, no export moved, and no accept set moved: this is a lint rule's false-positive set narrowing. `Clause-②: no`

.changeset/19248-duplicate-name-justification.md

@@ -0,0 +1,43 @@
+---
+'@objectstack/cli': patch
+---
+
+`collect-docs.ts` records what the `docs/duplicate-name` refusal rests on now that ADR-0048 §3.4 retired its older justification (#19248)
+
+`docs/duplicate-name` refuses two owners declaring one doc name. The claim it
+was once explained by — *"one registration overwrites the other"* — was retired
+by ADR-0048, and a refusal whose stated justification no longer exists is worth
+examining rather than inheriting second-hand. #19248 examined it.
+
+**The verdict is that no wording change was warranted**, and the ADR text is
+quoted into the rule's own docblock so the next reader does not have to
+re-derive it. §3.4 retires a RUNTIME throw and nothing else — *"The
+cross-package **throw is retired**; two distinct packages coexist on the same
+bare name by construction."* — while keeping, in the same clause, the class
+this lint belongs to: *"Authoring-time hygiene — an author shipping two
+`page/home` in one package — stays covered by the `naming/namespace-prefix`
+lint in `os lint`."* Both sentences are quoted verbatim, checked against
+`docs/adr/0048-cross-package-metadata-collision.md` on this branch's base
+(`13d52947d8`) rather than recalled.
+
+The message already said `for authoring hygiene` and already declined the
+retired claim by name, so what shipped was correct and stays byte-identical.
+What the docblock gains is the ADR's own words, the card number the standing
+**severity** disagreement is filed under, and the boundary between the two
+questions: §3.4 hands authoring hygiene to a warning-only lint while this one
+is `severity: 'error'`, which is a live question about the level and not about
+the reason.
+
+⛔ No behaviour changes. No rule, message, severity or accept set moves; the
+only edited bytes are inside one docblock comment.
+
+**This ships, which is why it carries a changeset rather than
+`skip-changeset`.** `@objectstack/cli`'s published `files[]` is
+`["dist","README.md","CHANGELOG.md"]` and the package builds with plain `tsc`
+(`tsc -p tsconfig.build.json`, no `removeComments`), so the comment is emitted
+into the tarball — measured on the rebuilt artifact: the new clause is present
+in `dist/utils/collect-docs.js` (1 occurrence), the replaced spelling is absent
+from all of `dist` (0), and `dist/**/*.d.ts` carries 0 of it because the block
+sits above a non-exported helper. The rule's own runtime message resolves to
+that same file as the positive control. So the published JS bytes move while
+the declaration surface does not.

.github/actions/setup-pnpm/action.yml

@@ -47,11 +47,15 @@
 # this action materialised the pin, with an assertion in between -- is what
 # makes a job structurally unable to donate an unpinned manager to the cache.
 #
-# Deliberately NOT in here: `actions/setup-node`. `scripts/check-node-version.mjs`
-# scans `.github/workflows/*.yml` ONLY, and reports how many setup-node steps it
-# audited. Moving those steps into this composite would drop them from its census
-# and it would still print OK -- a gate silently auditing less than it says.
-# Callers keep their own `setup-node` step, with its literal `node-version` pin.
+# Deliberately NOT in here: `actions/setup-node`. The reason was a gate's blind
+# spot -- `scripts/check-node-version.mjs` scanned `.github/workflows/*.yml`
+# only, so a setup-node step moved into this composite would have dropped out of
+# its census while it still printed OK, a gate silently auditing less than it
+# says. That blind spot is CLOSED (#19229): the census now reads
+# `.github/actions/**` as well, and a step's Node pin is audited wherever it is
+# written. The separation is kept anyway, because the callers' own pins are
+# already in place and moving them buys nothing -- ⛔ it is no longer a
+# constraint, and a future composition is free to hold one.
 
 name: Setup pnpm
 description: >-

.github/workflows/checklist-status.yml

@@ -114,10 +114,11 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v7
 
-      # Kept as this job's own step rather than folded into the composite below:
-      # `scripts/check-node-version.mjs` scans `.github/workflows/*.yml` only and
-      # reports how many setup-node steps it audited, so a step moved out of
-      # sight would silently shrink its census.
+      # Kept as this job's own step rather than folded into the composite below.
+      # ⛔ No longer because a gate cannot see it: `scripts/check-node-version.mjs`
+      # reads `.github/actions/**` too since #19229, so its census follows a
+      # setup-node step wherever it is written. Kept because the pin is already
+      # here and moving it buys nothing.
       - name: Setup Node.js
         uses: actions/setup-node@v7
         with:

.github/workflows/platform-checklist-watchdog.yml

@@ -193,9 +193,10 @@ jobs:
         uses: actions/checkout@v7
 
       # Kept as this job's own step rather than folded into the composite
-      # below: `scripts/check-node-version.mjs` scans `.github/workflows/*.yml`
-      # only and reports how many setup-node steps it audited, so a step moved
-      # out of sight would silently shrink its census.
+      # below. ⛔ No longer because a gate cannot see it:
+      # `scripts/check-node-version.mjs` reads `.github/actions/**` too since
+      # #19229, so its census follows a setup-node step wherever it is written.
+      # Kept because the pin is already here and moving it buys nothing.
       - name: Setup Node.js
         uses: actions/setup-node@v7
         with:

.github/workflows/test-nightly-tiers.yml

@@ -161,9 +161,10 @@ jobs:
         uses: actions/checkout@v7
 
       # Kept as this job's own step rather than folded into the composite
-      # below: `scripts/check-node-version.mjs` scans `.github/workflows/*.yml`
-      # only and reports how many setup-node steps it audited, so a step moved
-      # out of sight would silently shrink its census.
+      # below. ⛔ No longer because a gate cannot see it:
+      # `scripts/check-node-version.mjs` reads `.github/actions/**` too since
+      # #19229, so its census follows a setup-node step wherever it is written.
+      # Kept because the pin is already here and moving it buys nothing.
       - name: Setup Node.js
         uses: actions/setup-node@v7
         with:

packages/cli/src/utils/collect-docs.ts

@@ -934,8 +934,23 @@ function bodyDocsOf(packages: unknown, index: number): DocItem[] {
  * cross-package throw is retired"). What survives there is exactly what this
  * is: an authoring-time hygiene lint. ⚠️ That `os build` refuses the shape at
  * all is a standing disagreement with ADR-0048 §3.4 which PREDATES this card
- * and is filed rather than changed here — ⛔ relaxing a refusal that shipped is
- * not a rider on a widening.
+ * and is filed as #19248 rather than changed here — ⛔ relaxing a refusal that
+ * shipped is not a rider on a widening.
+ *
+ * #19248 read §3.4 back and settled the justification rather than moving it.
+ * The clause retires a RUNTIME throw and nothing else — *"The cross-package
+ * **throw is retired**; two distinct packages coexist on the same bare name by
+ * construction."* — while keeping the class this lint belongs to: *"Authoring-time
+ * hygiene — an author shipping two `page/home` in one package — stays covered by
+ * the `naming/namespace-prefix` lint in `os lint`."* So the reason stated above is
+ * the one that survived §3.4, and ⛔ no wording change was warranted. What #19248
+ * left open is the SEVERITY, not the reason: §3.4 hands authoring hygiene to a
+ * warning-only lint while this one is `severity: 'error'`.
+ *
+ * ⚠️ "this module's older framing" above is not gone — it is still live in this
+ * file's HEADER docblock, which states the retired claim as the current reason for
+ * the naming lints. Out of #19248's file surface (it also justifies
+ * `docs/namespace-prefix`), so it is reported, not edited here.
  */
 function lintDocNamesAcrossOwners(
   sets: ReadonlyArray<{ label: string; docs: readonly DocItem[] }>,