Skip to content

Commit 4aecf01

Browse files
committed
fix(spec): the joined-chart D3 entry ends on the house migrate sentence
The migrate-sentence class pin (repo project) judges semantic entries too: the sentence must be the house form and close the string. Claude-Session: https://claude.ai/code/session_01CiCTczDo7tGhafXjf61dUJ Co-authored-by: Claude <noreply@anthropic.com>
1 parent fdf804d commit 4aecf01

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

‎packages/spec/src/migrations/entries/semantic/18.ui-report-joined-chart-retired.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,16 @@ export const entry: SemanticMigration = {
5252
+ 'save door (the `report` entry of the metadata type registry, answered as '
5353
+ '`INVALID_METADATA` with status 422). A block `chart` is refused as an unrecognized key '
5454
+ 'on that block with the upgrade prescription; a container `chart` on a joined report is '
55-
+ 'one `custom` issue at `chart`. (1) No joined report carries a `chart` at either level: '
56-
+ 'run `os migrate meta --from 17` to list the mechanical strips for existing sources, and '
57-
+ 'the stored-row seams replay the same strip for rows at rest. (2) For every joined report '
55+
+ 'one `custom` issue at `chart`. (1) No joined report carries a `chart` at either level: the '
56+
+ 'D2 strip covers existing sources on a chain replay, and the stored-row seams replay it for '
57+
+ 'rows already at rest. (2) For every joined report '
5858
+ 'that carried one, decide whether the chart was wanted; if it was, a non-joined report '
5959
+ 'now binds that slice\'s dataset and carries the chart, and its `xAxis` / `yAxis` resolve '
6060
+ '(`validate-chart-bindings` checks them there). (3) Check the rendered joined report: it '
6161
+ 'renders exactly as before, because the chart was never drawn. A joined report with no '
6262
+ '`chart` parses byte-identically to before, and every non-joined report is untouched. '
6363
+ 'Census at the time of the change: zero joined reports with a chart in this repo\'s '
6464
+ 'example apps and in the hotcrm reference app, against a lit control (non-joined reports '
65-
+ 'carrying a chart: one and five).',
65+
+ 'carrying a chart: one and five). '
66+
+ 'Run `os migrate meta --from 17` to list the mechanical edits for existing sources; apply them by hand.',
6667
};

‎packages/spec/src/migrations/registry.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14754,17 +14754,18 @@ const step18: MigrationStep = {
1475414754
+ 'save door (the `report` entry of the metadata type registry, answered as '
1475514755
+ '`INVALID_METADATA` with status 422). A block `chart` is refused as an unrecognized key '
1475614756
+ 'on that block with the upgrade prescription; a container `chart` on a joined report is '
14757-
+ 'one `custom` issue at `chart`. (1) No joined report carries a `chart` at either level: '
14758-
+ 'run `os migrate meta --from 17` to list the mechanical strips for existing sources, and '
14759-
+ 'the stored-row seams replay the same strip for rows at rest. (2) For every joined report '
14757+
+ 'one `custom` issue at `chart`. (1) No joined report carries a `chart` at either level: the '
14758+
+ 'D2 strip covers existing sources on a chain replay, and the stored-row seams replay it for '
14759+
+ 'rows already at rest. (2) For every joined report '
1476014760
+ 'that carried one, decide whether the chart was wanted; if it was, a non-joined report '
1476114761
+ 'now binds that slice\'s dataset and carries the chart, and its `xAxis` / `yAxis` resolve '
1476214762
+ '(`validate-chart-bindings` checks them there). (3) Check the rendered joined report: it '
1476314763
+ 'renders exactly as before, because the chart was never drawn. A joined report with no '
1476414764
+ '`chart` parses byte-identically to before, and every non-joined report is untouched. '
1476514765
+ 'Census at the time of the change: zero joined reports with a chart in this repo\'s '
1476614766
+ 'example apps and in the hotcrm reference app, against a lit control (non-joined reports '
14767-
+ 'carrying a chart: one and five).',
14767+
+ 'carrying a chart: one and five). '
14768+
+ 'Run `os migrate meta --from 17` to list the mechanical edits for existing sources; apply them by hand.',
1476814769
},
1476914770
{
1477014771
id: 'ui-report-joined-container-selection-refused',

0 commit comments

Comments
 (0)