Skip to content

Commit 466593d

Browse files
committed
docs(tests): two docblocks stop citing files the retirement deleted
Both are comment-only; no assertion, no harness and no gate input moves. `plugin-audit/src/read-audit-view-instant-preservation.integration.test.ts` named `migrate-sys-notification-to-event.test.ts` and `packages/runtime/src/notification-migration-audit-preservation.integration.test.ts` as files a reader could go open. Both are absent from the tree (measured, with a sibling that IS present as the positive control). They are now marked retired; the first is kept because the SHAPE it demonstrated is the paragraph's point. `metadata/src/migrations/raw-exec-operator-detail-16657.test.ts` said "at the three `err?.message ?? String(err)` sites". Two remain. Measured rather than carried: the directory holds two `catch (err: any)` sites recording through `operatorFacingErrorText` and one `catch (error)` site, matching the docblock's own two-expression split; and the pre-merge tree of `d64bcb6377` shows the third in the deleted `migrate-sys-notification-to-event.ts`, which returned `{ outcome: 'failed', reason: err?.message ?? String(err) }`. Claude-Session: https://claude.ai/code/session_01DvvamiacK328idtBYJBxV3 Co-authored-by: Claude <noreply@anthropic.com>
1 parent bccdf6c commit 466593d

2 files changed

Lines changed: 12 additions & 5 deletions

File tree

packages/metadata/src/migrations/raw-exec-operator-detail-16657.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,16 @@
2323
* ⚠️ That channel is a RULE, not byte-identity with what these `catch` blocks
2424
* used to compute, and the negative pins below do not claim otherwise: each
2525
* throws a NON-EMPTY `new Error(…)`, the shape for which the rule and the old
26-
* expression agree. They differ elsewhere — at the three `err?.message ??
26+
* expression agree. They differ elsewhere — at the two `err?.message ??
2727
* String(err)` sites `new Error('')` recorded `''` and now records `'Error'`,
2828
* and `{message:42}` recorded the number where it now records
2929
* `'[object Object]'`; at the `error instanceof Error ? … : String(error)` site
3030
* `{message:'x'}` recorded `'[object Object]'` and now records `'x'`.
3131
*
32+
* ⚠️ Two, not the three this said when it was written. The third was
33+
* `migrateSysNotificationToEvent`, and it went with that runner when the
34+
* adr-0030-notification-event migration was retired.
35+
*
3236
* ⚠️ The composed sentence is the producer's, copied; `driver-sql`'s
3337
* `sql-driver-16657-operator-facing-cause-text.test.ts` pins the copy against a
3438
* real `SqlDriver.execute()` refusal.

packages/plugins/plugin-audit/src/read-audit-view-instant-preservation.integration.test.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,21 @@
1515
* the driver stores, on BOTH sides of any change to the write's context. The
1616
* case is green today, was green before #15964 flattened the ordinary insert
1717
* branch, and stays green after this card's fix. An instrument that cannot fail
18-
* is indistinguishable from a pass — the same shape that let
18+
* is indistinguishable from a pass — the same shape that let the since-retired
1919
* `migrate-sys-notification-to-event.test.ts` read `23 passed` for #16312 while
20-
* the rows it described were being restamped.
20+
* the rows it described were being restamped. That file went with the
21+
* adr-0030-notification-event migration it covered; it is named here for the
22+
* SHAPE it demonstrated, not as a file to go read.
2123
*
2224
* ⇒ this file is the instrument that CAN fail. It boots a real
2325
* {@link ObjectKernel} with the real {@link ObjectQLPlugin} (so the shipped
2426
* audit stamp hooks are registered) over a real {@link SqliteWasmDriver}, and
2527
* reads the persisted row back through the driver's own SQL surface.
2628
*
2729
* ⚠️ Unlike #16312's equivalent (`packages/runtime/src/notification-migration-
28-
* audit-preservation.integration.test.ts`), this one lives beside the code it
29-
* tests. That file had to leave `packages/metadata` because
30+
* audit-preservation.integration.test.ts`, retired together with the migration
31+
* it covered and no longer in the tree), this one lives beside the code it
32+
* tests. That file had had to leave `packages/metadata` because
3033
* `@objectstack/objectql` depends on it and the test-only import would have
3134
* closed a cycle. Here the edge already runs the other way —
3235
* `@objectstack/plugin-audit` depends on `@objectstack/objectql` — and

0 commit comments

Comments
 (0)