Skip to content

Commit 24ed6b9

Browse files
Merge branch 'main' into claude/issue-17516-permission-set-collision-diagnostic
2 parents 498f605 + 226970b commit 24ed6b9

101 files changed

Lines changed: 6760 additions & 1337 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.changeset/16236-formula-return-type-measure-column.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,19 @@
44

55
fix(service-analytics): a `min`/`max` over a `formula` field is typed from the formula's declared `returnType`, not described as `number` (#16236)
66

7+
> ⚠️ **Superseded within the same release window — ⛔ do not act on this entry.**
8+
> Everything below was accurate when it was written and is kept as the record of what
9+
> #16236 measured and built. It never reached a published version: **#17560** (director
10+
> ruling, decision batch #127, 2026-09-13) refuses `min` / `max` over a `formula` field
11+
> outright, on the compatibility table's own storage ground — a formula is VIRTUAL in SQL
12+
> storage, no column is emitted, so no aggregate can be lowered to it whatever
13+
> `returnType` says. At the version that compiles this entry such a measure answers
14+
> `DATASET_INVALID` / **400** at compile time instead of carrying any `fields[].type`, and
15+
> the `returnType?: string` member described at the foot of this entry is **not** on
16+
> `AnalyticsServiceConfig.sourceFieldMeta` — it was added and removed inside one release
17+
> window, so no published version ever carried it. ⇒ Read #17560's entry instead; the
18+
> FROM → TO below never became a shipped behaviour.
19+
720
**Behaviour change — read this if any dataset measure aggregates a `formula`
821
field.** `AnalyticsResult.fields[].type` for such a measure column was always
922
`number`, whatever the formula computes. It is now translated from the field's
@@ -47,3 +60,8 @@ a word outside the declared four: left alone, never guessed at.
4760
host that returns the three-member shape still satisfies the contract and gets
4861
exactly today's behaviour for every column. `AnalyticsServicePlugin` relays the
4962
key automatically, so a host on the plugin needs no change at all.
63+
64+
⚠️ **Superseded — see the banner at the top.** #17560 removed that member again in
65+
the same release window, so the shape a host writes against is the three-member one
66+
this paragraph calls today's. Nothing to do either way: a host that returns the
67+
fourth key is ignored, not refused.
Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
---
2+
"@objectstack/spec": minor
3+
---
4+
5+
feat(spec)!: `ListViewSchema.sort` retires the bare string clause — the PRODUCER half of the sort seam, so the contract stops minting documents its own consumer refuses (#17053; objectui#8221, decision batch #77 option B)
6+
7+
<!-- adr-0087: registered list-view-sort-string-clause-to-array -->
8+
9+
**BREAKING** accept-set narrowing at `view.sort` — the list-view doors
10+
(`ListViewSchema`, and the `ObjectListViewSchema` copy behind `object.list` /
11+
`object.listViews.*`) — shipped as `minor` under this repo's launch-window
12+
convention for breaking changes, the same grade its sibling
13+
`object-block-sort-item-array` took for the two `ComponentPropsMap` doors. The
14+
mechanical prescription is registered under protocol major 18 as
15+
`list-view-sort-string-clause-to-array`.
16+
17+
**Why this is graded on the seam, not on the string.** objectui ruled one sort
18+
orthography platform-wide — the array (objectui#8221, decision batch #77,
19+
2026-09-07, option B) — and objectui PR #8758 executes it: `convertSortToQueryParams`
20+
refuses a runtime string and its diagnostic names the array form. `ListViewSchema`
21+
is the producer of exactly those documents: `object.list.sort` is what
22+
`deriveRelatedLists` reads. So until this release a view authored with
23+
`sort: 'created_at desc'` **validated here, cleanly, and then failed downstream**
24+
the contract minting a shape its consumer rejects, with the author told off by
25+
the wrong layer. Re-measured on this tree before the change, with `bogusProp`
26+
refused by name on the same call as the firing control: `'name desc'`, `'-name'`
27+
and the array form all returned `success: true`, and only a bare number was
28+
refused (`sort/invalid_union`).
29+
30+
`sort` survives as a key, one union arm lighter, so this is a VALUE narrowing with
31+
no `retiredKey()` tombstone to hang a prescription on. The surviving array member's
32+
own `error` map carries it, keyed on `issue.input` being a string — the same shape
33+
`view.type`'s retired `'page'` value and `view.exportOptions`' retired `'pdf'` value
34+
already use in this schema. Every other invalid value (a number, an object, a
35+
string reaching a *descendant* such as a misspelled `order`) keeps zod's default
36+
report, so nobody is told a clause they never wrote "was removed".
37+
38+
**Migration** (`list-view-sort-string-clause-to-array`, a D2 conversion, not a
39+
semantic TODO — the rewrite is lossless and wholly mechanical):
40+
`sort: 'created_at desc'` becomes `sort: [{ field: 'created_at', order: 'desc' }]`;
41+
a bare field name meant ascending, so `sort: 'created_at'` becomes
42+
`sort: [{ field: 'created_at', order: 'asc' }]``order` is required on the entry
43+
and is written out rather than omitted; a comma-separated clause becomes one array
44+
entry per key, in the same order. `os migrate meta --from 17` lists these edits for
45+
author sources, and stored rows replay them through `applyConversionsToStoredItem`.
46+
47+
**The narrowing was not free, and the population was measured rather than assumed.**
48+
A tree-wide census over both the TS and JSON spellings of a string-valued `sort`,
49+
read as STRUCTURES rather than counted as tokens, found the clause authored on
50+
three live in-tree sites, all converted here: the shipped showcase list view
51+
`examples/app-showcase/src/ui/views/task.view.ts` (`'estimate_hours desc'`, carried
52+
since objectui#2601 as a deliberate live coverage fixture for the string form), the
53+
frozen `packages/lint` snapshot of that same shipped shape, and the published
54+
`skills/objectstack-ui` list-view rule. The census fired: it *found* documents, and
55+
`tsc` independently reds on the first two the moment the arm is removed. Sites
56+
deliberately NOT converted, having been read rather than grepped: ObjectQL
57+
`query.sort` and the wire `normalizeSortNodes` (different doors, different
58+
dialects), `packages/spec`'s `book`/`doc` field-mapping records whose `sort: 'order'`
59+
is an unrelated key of the same name, and the `packages/lint` rule fixtures, which
60+
feed the PRE-parse walker and never reach this schema.
61+
62+
**Not moved by this release.** `RecordRelatedListProps.sort` keeps its declared
63+
string arm. That string is the `'field'` / `'-field'` dialect normalised by
64+
objectui's own `RelatedList.normalizeSortSpec`; it never reaches
65+
`convertSortToQueryParams`, and retiring it was not ruled. For the same reason the
66+
conversion above declines any clause that does not parse as `<field> [asc|desc]`:
67+
guessing a direction for `'-name'` would invent an ordering the author never wrote,
68+
so on a list view it meets the door's prescription instead.
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
---
2+
'@objectstack/spec': minor
3+
'@objectstack/service-automation': minor
4+
---
5+
6+
A flow screen field can now express a numeric bound, help text and a lookup target — spelled with the object field's own key names
7+
8+
<!-- adr-0087: registered screen-field-lookup-reference-required -->
9+
10+
`ScreenFieldConfigSchema` was `.strict` over exactly
11+
`name`/`label`/`type`/`required`/`options`/`defaultValue`/`placeholder`/`visibleWhen`,
12+
so three ordinary authoring intents had **no expression at all**. They did not
13+
degrade quietly — `max`, `helpText` and every lookup-target spelling were
14+
refused BY NAME — but a loud refusal with no landing key is still a dead end,
15+
and the reference app worked around all three in prose: a discount ceiling
16+
interpolated into the `label` and the `placeholder` (with a comment explaining
17+
why there was no `max`), and a `type: 'lookup'` field whose `placeholder` asked
18+
a human to type a record id because the picker could not be pointed anywhere.
19+
20+
Four keys land, and **their names are derived from `FieldSchema`, not invented**
21+
— one platform, one field vocabulary, so a name learned on an object field means
22+
the same thing on a screen field:
23+
24+
| Key | Derived from | |
25+
|:---|:---|:---|
26+
| `min` / `max` | `FieldSchema.min` / `.max` | the bound pair |
27+
| `inlineHelpText` | `FieldSchema.inlineHelpText` | help under the input — `FieldSchema` renames `help`/`helpText`/`hint`/`tooltip` onto it, so a screen-local `helpText` would have been a second contract for one question |
28+
| `reference` | `FieldSchema.reference` | the object a `type: 'lookup'` field picks records from |
29+
30+
**The bound is enforced, not advisory.** It rides to the client on
31+
`ScreenFieldSpec` so the user is stopped at the input, **and**
32+
`validateScreenInputs` re-checks it when the run resumes (`min_value` /
33+
`max_value`, both already in the ADR-0114 D2 field-error catalog — no new error
34+
code). A screen field's declared contract is the only contract behind it, so a
35+
bound the dialog alone applied would be bypassed by any caller posting to
36+
`resume` directly — the gap #4477 closed for `required`.
37+
38+
That sentence needs no "when the value is a number" qualifier, because the
39+
value SHAPE is checked first: on a `type: 'number'` field a present value that
40+
is not a finite JSON number is refused with `invalid_type` (also already in the
41+
catalog — still no new code), ⛔ **not coerced**. Before this, a bound pass that
42+
compares numbers was satisfied by anything that never reached it, so `"25"`
43+
under a `max` of `20` was conformant. One member of the open `type` vocabulary
44+
is read as a value domain; every other widget hint stays open, and a bound on a
45+
non-numeric field still constrains nothing.
46+
47+
**Delivered with its rendering, not ahead of it.** The executor forwards all
48+
four onto the wire and the Studio designer form offers all four as repeater
49+
columns; `builtin-node-form-zod-ledger.test.ts` reconciles the two key sets
50+
against the Zod in both directions, so a key declared here and absent from the
51+
form fails that test rather than shipping as a field nobody can author.
52+
53+
**BREAKING** in the accept-set sense, in TWO places — landing as `minor` on
54+
both packages because the launch-window guard (`check-changeset-no-major`)
55+
keeps breaking changes off `major` outside pre-mode, not because the narrowing
56+
is small. Both were ruled (maintainer ruling A′, decision batch #130 item 1,
57+
2026-09-13); this release is **not** purely additive.
58+
59+
1. `reference` is **required** when `type` is `lookup`, as it is on an object
60+
field. A picker with no target object resolves nothing — ADR-0078's own
61+
example of silently-inert metadata — and a degraded shape that ships today
62+
is not a reason to bend the contract to it. A stored flow with a bare
63+
`lookup` screen field parsed before and does not now. There is **no lossless
64+
conversion**: nothing in the metadata says which object the author meant, so
65+
this is an ADR-0087 **semantic** migration entry — a structured TODO
66+
(`screen-field-lookup-reference-required`) that names the flow and the field
67+
for a human to answer — and ⛔ never a D2 conversion that would have to
68+
invent a target.
69+
2. A non-number submitted for a `type: 'number'` screen field is refused on
70+
resume (`invalid_type`) instead of passing silently. A resume bag that was
71+
accepted before can be refused now; it was never doing what its author
72+
declared.
73+
74+
Everything else is additive: the bound itself fires only on a field that
75+
declares one, which nothing did before this release.
76+
77+
The neighbouring spellings are refused **with their landing key** rather than
78+
with a bare key list: `help`/`helpText`/`hint`/`tooltip` name `inlineHelpText`,
79+
and `object`/`referenceTo`/`targetObject`/`lookupObject`/`relatedTo`/`target`
80+
name `reference`. ⚠️ `object` means different things one level apart — on the
81+
screen **node** it renames to `objectName`, on a screen **field** it can only
82+
mean the lookup target — so it earns its own row on both.
83+
84+
**One stale claim corrected in passing, because this change falsified it.** The
85+
flows translation surface documented `help`'s exclusion as *"`ScreenFieldConfig`
86+
declares nothing help-shaped at all"*, in `translation.zod.ts`'s guidance string
87+
(which enumerated the old key set verbatim), its doc block, and
88+
`i18n-resolver.ts`'s `FLOW_SCREEN_FIELD_COPY_KEYS`. The screen field now
89+
declares `inlineHelpText`, so the copy is real. The exclusion **stands** — the
90+
flows bundle still carries `label` and `placeholder` only, and growing that face
91+
is a ruled step against the #7646 enumeration, not a resolver-side accretion —
92+
but its reason is now stated as a not-yet instead of telling an author the field
93+
has no help copy when it has. ⛔ No translation key was added and no resolver
94+
behaviour moved.
Lines changed: 103 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,103 @@
1+
---
2+
"@objectstack/service-analytics": minor
3+
"@objectstack/spec": minor
4+
---
5+
6+
feat(service-analytics)!: `min` and `max` are judged by the aggregate × field-type table too — all 74 refused pairs answer `400 DATASET_INVALID` through one compile door (#17560)
7+
8+
<!-- adr-0087: registered dataset-measure-selecting-aggregate-field-type-refused -->
9+
10+
**BREAKING** — an accept-set narrowing on a published authoring surface, and the last
11+
one this table owed. A dataset measure pairing `aggregate: 'min'` (or `'max'`) with any
12+
of the **37** field types outside the numeric, temporal and boolean classes — for example
13+
`text`, `select`, `lookup`, `autonumber`, `json`, `multiselect`, `file`, `location`,
14+
`vector` or `formula`; the ADR-0087 entry registered below carries the full list — used to
15+
compile and reach the backend; it is now refused by
16+
`compileDataset` with `DATASET_INVALID` / **400** before any query is built. Shipped as
17+
`minor` under the repo's launch-window convention for accept-set narrowings.
18+
19+
⛔ This changeset adds no rows to any table and restates none. The verdict is
20+
`AGGREGATE_FIELD_TYPE_COMPATIBILITY`'s — the one table `@objectstack/spec` declared in
21+
#16353 under the director ruling of decision batch #59 ("both legs, table in spec") —
22+
read through `isAggregateCompatibleWithFieldType`.
23+
24+
## What was wrong
25+
26+
The table refused these 74 pairs from the day it was declared, and **four declarations
27+
gave three different answers about them**:
28+
29+
| declaration | what it said about `min` × `text` |
30+
|---|---|
31+
| `AGGREGATE_FIELD_TYPE_COMPATIBILITY` (spec) | refused |
32+
| `dataset-compiler`'s compile leg | never judged — `if (!DERIVING_AGGREGATES.has(aggregate)) return;` |
33+
| `measureResultType` (service-analytics, #15768) | a supported `'string'` result |
34+
| two shipped test files, in prose | "ruled C — the table is to be AMENDED to accept it" |
35+
36+
Driven through the real service door before anything was written, `min` / `max` over 13
37+
sampled refused pairs all compiled and emitted SQL, with `avg` × `datetime` as the
38+
firing control (refused, `DATASET_INVALID` / 400, no SQL) — so the zero was a reading of
39+
the tree rather than of a blind harness.
40+
41+
The fourth row had nothing behind it. The card it cited (#17513) is closed as a
42+
duplicate carrying zero rulings, and the one recorded ruling on this table says the
43+
opposite. ⇒ The director ruling of decision batch #127 (2026-09-13) settled all three
44+
sub-questions in one pass, because one shared fixture drove members of both halves:
45+
46+
1. **the string classes** (42 pairs) stay refused, as batch #59 ruled — ⛔ the table is
47+
not amended;
48+
2. **the non-string classes** (32 pairs) are refused **and enforced**;
49+
3. **`formula`** is refused on the table's own storage ground — it is VIRTUAL in SQL
50+
storage, no column is emitted, so no aggregate can be lowered to it whatever
51+
`returnType` says.
52+
53+
The divergence is real, and for these two aggregates it is the **ORDER** rather than the
54+
arithmetic: string order is collation-dependent, so two backends answer two different
55+
"smallest" values for one metadata document, and `min(jsonb)` does not exist on
56+
PostgreSQL at all.
57+
58+
## What changed
59+
60+
- **`dataset-compiler`**: the scope condition is gone. `assertAggregateFieldTypeCompatible`
61+
judges all six `AggregationFunction` members against the table, through the same
62+
`DATASET_INVALID` / 400 door. The refusal message names the divergence its own
63+
aggregate class really has (`min` / `max` SELECT a stored value and diverge on order;
64+
`sum` / `avg` DERIVE a number and diverge on arithmetic) and prescribes accordingly.
65+
- **`measureResultType`** asks `isAggregateCompatibleWithFieldType` before it answers, so
66+
the rule and the table agree **by construction**. Its `STRING_SOURCE_FIELD_TYPES`
67+
branch and its `formula` branch are retired with them; `min` / `max` over the temporal
68+
class still answers `'time'`, unchanged.
69+
- **`AnalyticsServiceConfig.sourceFieldMeta`** no longer declares `returnType`. It was
70+
carried (#16236) for one reader — the retired `formula` branch — and a declared input
71+
nobody consumes is the declared-not-enforced shape Prime Directive #10 refuses.
72+
73+
⚠️ **That key was never released, so against every published version this removal is a
74+
no-op.** #16236 is still a pending changeset in the same release window as this one;
75+
the last published entry (17.4.0) says in as many words that `FieldSchema.returnType`
76+
"is not on `AnalyticsServiceConfig.sourceFieldMeta`'s return shape". The key was
77+
therefore added and removed inside one window and no published tarball ever carried it.
78+
79+
**Host fix, one line:** drop `returnType` from whatever your `sourceFieldMeta` returns.
80+
You do not have to — the hook is a function RETURN position, so an extra key is not an
81+
excess-property error and is simply ignored at runtime — but keeping it declares an
82+
input nothing reads. Hosts on `AnalyticsServicePlugin` need no change at all: the plugin
83+
stopped relaying the key in this same change.
84+
85+
## FROM → TO, and the one-line fix
86+
87+
| you wrote | write instead |
88+
|---|---|
89+
| `{ aggregate: 'min' \| 'max', field: <a text/select/lookup/autonumber field> }` | `count` / `count_distinct` if you were counting; a **sort** on the list/report if you wanted the first or last RECORD |
90+
| `{ aggregate: 'min' \| 'max', field: <a json/multiselect/file/location/vector field> }` | store the quantity you meant as a numeric or temporal field and aggregate that |
91+
| `{ aggregate: 'min' \| 'max', field: <a formula field> }` | a formula emits no column; aggregate the stored field the formula reads, or persist the computed value |
92+
93+
⚠️ **Untouched:** those field types used as a **DIMENSION** (grouping, labelling,
94+
bucketing, filtering), `count` / `count_distinct` over any type, `min` / `max` over the
95+
numeric, temporal and boolean classes, and every `sum` / `avg` row #16778 and #16099
96+
already settled. The refusal also still stands down rather than guessing wherever the
97+
declared type cannot be resolved: no `sourceFieldMeta` wired, an unknown field, or a
98+
`relationship.field` path whose column lives on a joined object.
99+
100+
⚠️ The hand-migration prescription ships as the ADR-0087 semantic TODO registered above,
101+
which names the measure and the field type per affected pair — no lossless conversion
102+
exists, because nothing can compute "the smallest text value" in a way every backend
103+
agrees on.

0 commit comments

Comments
 (0)