Skip to content

Commit 16b5bf6

Browse files
committed
docs(metadata-protocol): re-anchor the remaining dead tracker and comment-id citations in test comments
Stage 2 of the domain:engine lane's dead-citation sweep, packages/metadata-protocol only: the 22 test-comment sites carrying 13 numbers that answer 404 (which the census never reads), the dead comment-id citation on two lines, and the dead convenience PR number beside commit 9632604. Each now cites the commit in this repository's history that made the decision the sentence describes (ruling C+D form C). Comment prose only; every file keeps its line count. Claude-Session: https://claude.ai/code/session_017xfMoEjKUuSh2xYB8sCozp Co-authored-by: Claude <noreply@anthropic.com>
1 parent a7d9768 commit 16b5bf6

16 files changed

Lines changed: 23 additions & 23 deletions

‎packages/metadata-protocol/src/discovery-schema-conformance.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ describe('[#4828] getDiscovery() conforms to DiscoverySchema', () => {
303303
expect(DiscoverySchema.safeParse(discovery).success).toBe(true);
304304
});
305305

306-
// [#6287] `preview` left this list when it stopped being unrecognised: it is
306+
// [commit 84c86fb45] `preview` left this list when it stopped being unrecognised: it is
307307
// a declared `EnvironmentTypeSchema` member and now has a stated fold
308308
// (`sandbox`), so asserting `development` for it here would assert the
309309
// opposite of the mapper's decision. The RULE these rows pin — an unknown

‎packages/metadata-protocol/src/get-meta-item-org-read-gate.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
* ── The defect, and why the singular verb is the sharper half ─────────────
99
*
10-
* Commit 96326040f (PR #14767) moved {@link organizationIdForMetaRead} INSIDE the PLURAL
10+
* Commit 96326040f moved {@link organizationIdForMetaRead} INSIDE the PLURAL
1111
* verb, `getMetaItems`, and deliberately did not carry to this one. There, the
1212
* two `queryByOrg` reads are UNIONed, so an ungated organization can only ADD
1313
* rows — the resurrection that card is about. Here the two `findOverlay` reads

‎packages/metadata-protocol/src/get-meta-items-org-read-gate.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ function makeHarness(rows: StoredRow[]) {
121121
return (r as unknown as Record<string, unknown>)[k] === v;
122122
}),
123123
);
124-
// `check:objectql-double-limit` (#10978) — hold the caller's bound,
124+
// `check:objectql-double-limit` (commit 4c9780c7a) — hold the caller's bound,
125125
// applied AFTER the filter and BY PRESENCE.
126126
return opts?.limit === undefined ? matched : matched.slice(0, opts.limit);
127127
},

‎packages/metadata-protocol/src/meta-overlay-cache.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ function makeHarness(rows: StoredRow[], options: HarnessOptions = {}) {
176176
return (r as unknown as Record<string, unknown>)[k] === v;
177177
}),
178178
);
179-
// `check:objectql-double-limit` (#10978) — hold the caller's bound,
179+
// `check:objectql-double-limit` (commit 4c9780c7a) — hold the caller's bound,
180180
// applied AFTER the filter and BY PRESENCE. A double that hands
181181
// back every row it matched cannot tell a dropped bound from no
182182
// bound at all.

‎packages/metadata-protocol/src/migrations/read-probe.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* instead. The MySQL arm runs against a real server in
3131
* \`seed-tenancy-backfill.live-mysql.test.ts\`; the SQLite arm end to end against
3232
* a real \`SqlDriver\` in \`packages/runtime\`'s
33-
* \`seed-tenancy-autonumber-split.integration.test.ts\`; and [#17621] the POSTGRES
33+
* \`seed-tenancy-autonumber-split.integration.test.ts\`; and [commit 7e74af3df] the POSTGRES
3434
* arm — recorded here as NOT MEASURED anywhere for as long as that was true —
3535
* now runs in \`seed-tenancy-backfill.live-postgres.test.ts\`, on the postgres
3636
* service the \`Temporal Conformance\` job already provisions. All three arms are

‎packages/metadata-protocol/src/migrations/seed-tenancy-backfill.live-postgres.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
22

33
/**
4-
* #17621 — the seed-tenancy backfill's statements, RUN on a live PostgreSQL.
4+
* Commit 7e74af3df — the seed-tenancy backfill's statements, RUN on a live PostgreSQL.
55
*
66
* ## The gap this closes
77
*
@@ -52,7 +52,7 @@
5252
* uses) and reports a named SKIP without one — never a silent pass. A runner
5353
* that knows it provisioned the server sets `OS_EXPECT_LIVE_DIALECT_MATRIX=1`,
5454
* which turns the missing URL into a failure, so a dropped `env:` line cannot
55-
* quietly return this seam to the no-coverage state #17621 records.
55+
* quietly return this seam to the no-coverage state commit 7e74af3df records.
5656
*
5757
* ## Isolation — a per-file SCHEMA, and why the resolver is the MySQL-named one
5858
*
@@ -253,7 +253,7 @@ describe.skipIf(!PG_URL)('#17621 seed-tenancy backfill on a LIVE PostgreSQL', ()
253253
const statements: Array<[string, string, unknown[]]> = [
254254
['presence probe (fallback arm)', buildSequencesPresenceSql(c), []],
255255
// The statement the boot path actually runs now. It is in this list for
256-
// the reason every other one is here, and #17621 exists because it was
256+
// the reason every other one is here, and commit 7e74af3df exists because it was
257257
// the ONE arm this list could not previously contain.
258258
['presence probe (catalog arm)', buildTablePresenceSql(SEQUENCES_TABLE, c) as string, []],
259259
['split probe', buildSplitProbeSql(c), [GLOBAL_TENANT, GLOBAL_TENANT]],

‎packages/metadata-protocol/src/protocol-publish-drafts-closure.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
* The `objects` and `permissions` gaps are the same defect at advisory
3636
* severity: they do not refuse, they manufacture findings that describe
3737
* nothing. Both are pinned below, because a closure that is uniform is the
38-
* property #9612/#10058 declared and a per-collection patch is what produced
38+
* property #9612/commit 6f5a44976 declared and a per-collection patch is what produced
3939
* this card.
4040
*
4141
* ## The discriminating tests are the ones that expect SILENCE

‎packages/metadata-protocol/src/protocol-publish-drafts-object-field-refs.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ describe('publishPackageDrafts refuses a dangling object field-name list (#15254
244244
expect(causal.code).toBe('INVALID_METADATA');
245245

246246
// …with a rule id and the offending path, which is what has to reach
247-
// the author's screen. The path is name-keyed on the wire (#10064) —
247+
// the author's screen. The path is name-keyed on the wire (commit def0d3e63) —
248248
// `objects.<name>.<key>[i]`, never the gate's private snapshot index.
249249
const wire = JSON.stringify(causal);
250250
expect(wire).toContain('object-field-ref-unknown');

‎packages/metadata-protocol/src/protocol.batch-row-http-status.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ describe('[#14723] section 7 — a `DuplicateRecordError` row reports `UNIQUE_VI
543543
});
544544

545545
it('[GUARD] a producer that merely SPEAKS `DUPLICATE_RECORD` is not the engine\'s envelope and keeps its own code', async () => {
546-
// The same discrimination the whole-request arm makes (#14389 §5):
546+
// The same discrimination the whole-request arm makes (commit 10220a7bf):
547547
// the gate is the registered code AND the class name. A hook throwing
548548
// the registered member from its own body is a different producer
549549
// speaking a member of the vocabulary; the verbatim rule still applies.

‎packages/metadata-protocol/src/protocol.datasource-delete-prolongation.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* re-verification carrier: re-measure the prolongation once that fix lands, and
1818
* close only on the measurement.
1919
*
20-
* The re-verification (PR #14431) found that #13331 closes the registry-heal
20+
* The re-verification (commit a98b61b3e) found that #13331 closes the registry-heal
2121
* half but opens a SECOND gap on the read-in-window path (see "Arms" below,
2222
* preserved as history). Ruling A′ (2026-09-03, director batch #22, comment
2323
* 5528370129) ordered the fix for that gap: `applyRemoteMetadataMutation`
@@ -110,7 +110,7 @@
110110
* writes the deleted row straight back into the registry the bridge
111111
* just healed — and the registry has no TTL.
112112
*
113-
* So the prolongation was — PR #14431's finding, kept as history below —
113+
* So the prolongation was — commit a98b61b3e's finding, kept as history below —
114114
* neither unconditionally bounded nor unconditionally unbounded, and the
115115
* discriminator was not time but TRAFFIC:
116116
*
@@ -132,7 +132,7 @@
132132
* one. The bounded arm is the quiet-replica arm.
133133
*
134134
* ---------------------------------------------------------------------------
135-
* Why the re-hydration USED TO happen, precisely (history — PR #14431)
135+
* Why the re-hydration USED TO happen, precisely (history — commit a98b61b3e)
136136
* ---------------------------------------------------------------------------
137137
* Nothing on the bridge's receipt path touched the WRITE EPOCH that keys the
138138
* overlay cache. `applyRemoteMetadataMutation` re-read the row and repaired the
@@ -180,7 +180,7 @@
180180
* re-derived (the dispatch forbids re-deriving that finding).
181181
* 3. list-cache TTL (#5109) ............. RE-MEASURED, then CLOSED. At this
182182
* door the cache is `meta-overlay-cache`, not `MetadataManager.listCache` —
183-
* PR #14431 found it did not merely delay the correct answer, it FED the
183+
* commit a98b61b3e found it did not merely delay the correct answer, it FED the
184184
* untimed registry, converting a 30s residue into an unbounded one on any
185185
* read landing in the window. Ruling A′'s bump on the receipt path retires
186186
* this cache at the moment of convergence, so the read that follows has
@@ -691,7 +691,7 @@ describe('[#13609] ⭐ the re-verification: how long does the peer keep serving
691691

692692
// `measureProlongationMs` reads the door once BEFORE advancing the
693693
// clock — i.e. inside the residue window, which is what a replica
694-
// under load does continuously. Previously (PR #14431) that read
694+
// under load does continuously. Previously (commit a98b61b3e) that read
695695
// converted the bounded cache residue into an unbounded registry
696696
// entry. Now the convergence bump has already retired the cache
697697
// before this first read runs, so the read-in-window traffic

0 commit comments

Comments
 (0)