Merge branch '159-fix-trigger-reconnect-result' into 'main'

Don't throw on triggerReconnect failure #159

See merge request objectbox/objectbox-dart!118

Author: greenrobot-team

objectbox/lib/src/native/sync.dart

@@ -407,14 +407,13 @@ class SyncClient {
     checkObx(C.sync_stop(_ptr));
   }
 
-  /// Triggers a reconnection attempt immediately.
+  /// Triggers a reconnection attempt immediately. Returns if a reconnect was
+  /// actually triggered.
   ///
   /// By default, an increasing backoff interval is used for reconnection
   /// attempts. But sometimes the code using this API has additional knowledge
   /// and can initiate a reconnection attempt sooner.
-  void triggerReconnect() {
-    checkObx(C.sync_trigger_reconnect(_ptr));
-  }
+  bool triggerReconnect() => checkObxSuccess(C.sync_trigger_reconnect(_ptr));
 
   /// Request updates since we last synchronized our database.
   ///

objectbox_test/test/sync_test.dart

@@ -207,7 +207,7 @@ void main() {
       expect(() => c.setRequestUpdatesMode(SyncRequestUpdatesMode.auto), error);
     });
 
-    test('SyncClient simple coverage (no server available)', () {
+    test('SyncClient simple coverage (no server available)', () async {
       SyncClient c = createClient(store);
       expect(c.isClosed(), isFalse);
 
@@ -234,12 +234,20 @@ void main() {
       expect(c.requestUpdates(subscribeForFuturePushes: true), isFalse);
       expect(c.requestUpdates(subscribeForFuturePushes: false), isFalse);
       expect(c.outgoingMessageCount(), isZero);
-      if (Platform.isWindows) {
-        print(
-            'Skipping triggerReconnect on Windows, needs fixing, see objectbox-dart#159');
-      } else {
-        c.triggerReconnect();
+      // Wait until client reaches state disconnected (as there is no server),
+      // only then reconnect will be attempted.
+      var waitedForDisconnected = 0;
+      while (c.state() != SyncState.disconnected) {
+        if (waitedForDisconnected == 0) {
+          print('Waiting until SyncClient state is disconnected...');
+        }
+        if (waitedForDisconnected == 50) {
+          fail('SyncClient did not reach disconnected state within 5 seconds');
+        }
+        await Future.delayed(const Duration(milliseconds: 100));
+        waitedForDisconnected++;
       }
+      expect(c.triggerReconnect(), true);
       c.stop();
       expect(c.state(), equals(SyncState.stopped));
     });