refactor: return early if no options

Jamie Tanna · jamietanna · commit 750f72e3e7e5 · 2025-04-25T07:35:12.000+01:00
As it simplifies the readability of the checks.
diff --git a/oapi_validate.go b/oapi_validate.go
@@ -76,10 +76,13 @@ func OapiRequestValidatorWithOptions(spec *openapi3.T, options *Options) func(ne
 				return
 			}
 
-			if options != nil && options.ErrorHandler != nil {
-				options.ErrorHandler(w, err.Error(), statusCode)
-			} else {
+			if options == nil {
 				http.Error(w, err.Error(), statusCode)
+				return
+			}
+
+			if options.ErrorHandler != nil {
+				options.ErrorHandler(w, err.Error(), statusCode)
 			}
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,13 @@ func OapiRequestValidatorWithOptions(spec openapi3.T, options Options) func(ne`
`76`	`76`	`return`
`77`	`77`	`}`
`78`	`78`
`79`		`- if options != nil && options.ErrorHandler != nil {`
`80`		`- options.ErrorHandler(w, err.Error(), statusCode)`
`81`		`- } else {`
	`79`	`+ if options == nil {`
`82`	`80`	`http.Error(w, err.Error(), statusCode)`
	`81`	`+ return`
	`82`	`+ }`
	`83`	`+`
	`84`	`+ if options.ErrorHandler != nil {`
	`85`	`+ options.ErrorHandler(w, err.Error(), statusCode)`
`83`	`86`	`}`
`84`	`87`	`})`
`85`	`88`	`}`