refactor(ShareButton): Refactored duplicate call via setTimeout in favor of a reliable solution specific to my use-case

Author: Kashuab

src/ShareButton.tsx

@@ -81,9 +81,9 @@ interface CustomProps<LinkOptions> {
   openShareDialogOnClick?: boolean;
   opts: LinkOptions;
   /**
-   * URL of the shared page
+   * URL of the shared page, can be an async function that resolves a URL
    */
-  url: string;
+  url: string | (() => Promise<string>);
   style?: React.CSSProperties;
   windowWidth?: number;
   windowHeight?: number;
@@ -92,7 +92,8 @@ interface CustomProps<LinkOptions> {
    *  Takes a function that returns a Promise to be fulfilled before calling
    * `onClick`. If you do not return promise, `onClick` is called immediately.
    */
-  beforeOnClick?: () => Promise<void> | void;
+  beforeOnClick?: () => void | Promise<void>;
+
   /**
    * Takes a function to be called after closing share dialog.
    */
@@ -132,20 +133,22 @@ export default class ShareButton<LinkOptions> extends Component<Props<LinkOption
     windowOpen(link, windowConfig, onShareWindowClose);
   };
 
-  handleClick = async (
-    event: React.MouseEvent<HTMLButtonElement>,
-    ignoreBeforeOnClick = false,
-  ): Promise<void> => {
+  handleClick = async (event: React.MouseEvent<HTMLButtonElement>): Promise<void> => {
     const {
       beforeOnClick,
       disabled,
       networkLink,
       onClick,
-      url,
       openShareDialogOnClick,
       opts,
     } = this.props;
 
+    let url = this.props.url;
+
+    if (typeof url == 'function') {
+      url = await url();
+    }
+
     const link = networkLink(url, opts);
 
     if (disabled) {
@@ -154,19 +157,12 @@ export default class ShareButton<LinkOptions> extends Component<Props<LinkOption
 
     event.preventDefault();
 
-    if (beforeOnClick && !ignoreBeforeOnClick) {
-      // Make the event object usuable in the following handleClick call
-      event.persist();
-
+    if (beforeOnClick) {
       const returnVal = beforeOnClick();
 
       if (isPromise(returnVal)) {
         await returnVal;
       }
-
-      // beforeOnClick could change our props, so let's re-run handleClick
-      setTimeout(() => this.handleClick(event, true));
-      return;
     }
 
     if (openShareDialogOnClick) {