Add validation and tests for invalid data creation and serialization

Refactor the `BaseData::create` method to handle invalid input more effectively, using a specific exception for clarity. Introduce `UselessDataCipher` as a test dummy and add unit tests to ensure proper exception handling for invalid serialization and data creation.

Author: Fa-BRAIK

src/Concerns/BaseData.php

@@ -21,20 +21,12 @@ trait BaseData
      */
     final public static function create(mixed ...$args): static
     {
-        if (array_any(
-            array_keys($args),
-            static fn (string|int $arg) => is_numeric($arg)
-        )) {
-            throw DataCreationException::invalidProperty();
-        }
-
         try {
-            $value = static::normalizeValue($args, static::class);
+            $value = static::normalizeValue($args, static::class)
+                ?: static::normalizeValue($args[0] ?? [], static::class);
 
             if ($value === false) {
-                throw new DeserializeException(
-                    code: DeserializeException::INVALID_VALUE_ERROR_CODE
-                );
+                throw DataCreationException::invalidParamsPassed(static::class);
             }
 
             /** @var ClassContext<static> $context */

tests/Dummies/DataCiphers/UselessDataCipher.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace Nuxtifyts\PhpDto\Tests\Dummies\DataCiphers;
+
+use Nuxtifyts\PhpDto\DataCiphers\DataCipher;
+use Nuxtifyts\PhpDto\Exceptions\DataCipherException;
+
+class UselessDataCipher implements DataCipher
+{
+
+    /**
+     * @throws DataCipherException
+     */
+    public static function cipher(mixed $data, string $secret, bool $encode = false): never
+    {
+        throw DataCipherException::failedToCipherData();
+    }
+
+    /**
+     * @throws DataCipherException
+     */
+    public static function decipher(string $data, string $secret, bool $decode = false): never
+    {
+        throw DataCipherException::failedToDecipherData();
+    }
+}

tests/Unit/Concerns/BaseDataTest.php

@@ -4,8 +4,10 @@
 
 use DateTimeImmutable;
 use DateTimeInterface;
+use Nuxtifyts\PhpDto\Attributes\Property\CipherTarget;
 use Nuxtifyts\PhpDto\Attributes\Property\Computed;
 use Nuxtifyts\PhpDto\Data;
+use Nuxtifyts\PhpDto\Exceptions\DataCreationException;
 use Nuxtifyts\PhpDto\Exceptions\DeserializeException;
 use Nuxtifyts\PhpDto\Exceptions\SerializeException;
 use Nuxtifyts\PhpDto\Pipelines\DeserializePipeline\DeserializePipeline;
@@ -21,6 +23,7 @@
 use Nuxtifyts\PhpDto\Tests\Dummies\ComputedPropertiesData;
 use Nuxtifyts\PhpDto\Tests\Dummies\CoordinatesData;
 use Nuxtifyts\PhpDto\Tests\Dummies\CountryData;
+use Nuxtifyts\PhpDto\Tests\Dummies\DataCiphers\UselessDataCipher;
 use Nuxtifyts\PhpDto\Tests\Dummies\Enums\YesNoBackedEnum;
 use Nuxtifyts\PhpDto\Tests\Dummies\FallbackResolvers\DummyPointsFallbackResolver;
 use Nuxtifyts\PhpDto\Tests\Dummies\InvitationData;
@@ -54,6 +57,7 @@
 #[CoversClass(DateTimeSerializer::class)]
 #[CoversClass(DataSerializer::class)]
 #[CoversClass(BackedEnumSerializer::class)]
+#[CoversClass(DataCreationException::class)]
 #[UsesClass(PersonData::class)]
 #[UsesClass(UnionTypedData::class)]
 #[UsesClass(YesOrNoData::class)]
@@ -70,6 +74,7 @@
 #[UsesClass(PointGroupData::class)]
 #[UsesClass(PointData::class)]
 #[UsesClass(DummyPointsFallbackResolver::class)]
+#[UsesClass(UselessDataCipher::class)]
 final class BaseDataTest extends UnitCase
 {
     /**
@@ -591,6 +596,29 @@ public static function will_perform_serialization_and_deserialization_data_provi
         ];
     }
 
+    #[Test]
+    public function will_throw_an_exception_when_property_serialization_fails(): void
+    {
+        $object = new readonly class ('secret') extends Data {
+            public function __construct(
+                #[CipherTarget(UselessDataCipher::class)]
+                public string $secret
+            ) {
+            }
+        };
+
+        self::expectException(SerializeException::class);
+        $object->jsonSerialize();
+    }
+
+    #[Test]
+    public function will_throw_an_exception_when_invalid_data_is_passed_to_create_function(): void
+    {
+        self::expectException(DataCreationException::class);
+
+        PointData::create('{"x: 1, "y": 2}');
+    }
+
     /**
      * @throws Throwable
      */
@@ -606,6 +634,12 @@ public function will_be_able_to_create_an_instance_using_create(): void
         self::assertEquals(1, $point->x);
         self::assertEquals(2, $point->y);
 
+        $point = PointData::create('{"x": 3, "y": 4}');
+
+        self::assertInstanceOf(PointData::class, $point);
+        self::assertEquals(3, $point->x);
+        self::assertEquals(4, $point->y);
+
         // Make sure we skip deciphering the key
         $pointGroup = PointGroupData::create(
             key: 'random-key'