gracefully handle missing extrae ON/OFF events

should resolve #24

Author: ptooley

pypop/notebook_interface/wizard.py

@@ -149,6 +149,7 @@ def _calculate_callback_hook(self, callback_reference=None):
                 force_recalculation=advanced_config["Delete Cache"].value,
                 chop_to_roi=advanced_config["Chop to ROI"].value,
                 no_progress=True,
+                chop_fail_is_error=True
             )
         except ExtraePRVNoOnOffEventsError as err:
             fileprogress = tqdm_notebook_noauto(self._fileselector.filenames, leave=False)

pypop/trace/prvtrace.py

@@ -13,13 +13,13 @@
 from .trace import Trace
 
 from ..utils.io import zipopen
-from ..utils.exceptions import WrongLoaderError
+from ..utils.exceptions import WrongLoaderError, ExtraePRVNoOnOffEventsError
 
 from ..dimemas import dimemas_idealise
 from ..extrae import paramedir_analyze_any_of, chop_prv_to_roi, remove_trace
 
 base_configs = {
-    k: tuple(resource_filename('pypop', w) for w in v)
+    k: tuple(resource_filename("pypop", w) for w in v)
     for k, v in {
         "Serial Useful Computation": (
             "cfgs/serial_useful_computation.cfg",
@@ -37,7 +37,7 @@
 }
 
 omp_configs = {
-    k: tuple(resource_filename('pypop', w) for w in v)
+    k: tuple(resource_filename("pypop", w) for w in v)
     for k, v in {
         "OpenMP Total Runtime": (
             "cfgs/omp_total_runtime.cfg",
@@ -53,7 +53,7 @@
 }
 
 ideal_configs = {
-    k: tuple(resource_filename('pypop', w) for w in v)
+    k: tuple(resource_filename("pypop", w) for w in v)
     for k, v in {
         "Ideal Useful Computation": ("cfgs/total_useful_computation.cfg",),
         "Ideal Runtime": ("cfgs/total_runtime.cfg",),
@@ -120,6 +120,7 @@ def _gather_statistics(self):
             self._tracefile,
             self._kwargs.get("chop_to_roi", False),
             self._kwargs.get("outpath", None),
+            self._kwargs.get("chop_fail_is_error", False)
         )
 
     @staticmethod
@@ -142,19 +143,26 @@ def _split_layoutstring(prv_td):
         return (commsize, threads)
 
     @staticmethod
-    def _analyze_tracefile(trace, chop_to_roi, outpath):
+    def _analyze_tracefile(trace, chop_to_roi, outpath, chop_fail_is_error):
         if outpath:
             makedirs(outpath, exist_ok=True)
 
-        if chop_to_roi:
-            if outpath:
-                tgtname = ".chop".join(splitext(basename(trace)))
-                outfile = path_join(outpath, tgtname)
+        try:
+            if chop_to_roi:
+                if outpath:
+                    tgtname = ".chop".join(splitext(basename(trace)))
+                    outfile = path_join(outpath, tgtname)
+                else:
+                    outfile = None
+                    cut_trace = chop_prv_to_roi(trace, outfile)
             else:
-                outfile = None
-                cut_trace = chop_prv_to_roi(trace, outfile)
-        else:
+                cut_trace = trace
+        except ExtraePRVNoOnOffEventsError as err:
+            if chop_fail_is_error:
+                raise err
+            warn("Unable to chop to ROI: ({}) - Continuing without chopping".format(err))
             cut_trace = trace
+            chop_to_roi = False
 
         stats = [
             paramedir_analyze_any_of(

pypop/traceset.py

@@ -67,6 +67,7 @@ def __init__(
         outpath=None,
         ignore_cache=None,
         tag=None,
+        chop_fail_is_error=False,
     ):
         # Setup data structures
         self.traces = set()
@@ -80,7 +81,13 @@ def __init__(
 
         # Add traces
         self.add_traces(
-            path_list, force_recalculation, chop_to_roi, no_progress, outpath, tag
+            path_list,
+            force_recalculation,
+            chop_to_roi,
+            no_progress,
+            outpath,
+            tag,
+            chop_fail_is_error,
         )
 
     def add_traces(
@@ -91,6 +98,7 @@ def add_traces(
         no_progress=False,
         outpath=None,
         tag=None,
+        chop_fail_is_error=False,
     ):
         """Collect statistics from provided trace files, currently only Extrae .prv files
         are supported.
@@ -140,6 +148,7 @@ def add_traces(
                         chop_to_roi=chop_to_roi,
                         outpath=outpath,
                         tag=tag,
+                        chop_fail_is_error=chop_fail_is_error,
                     )
                 )