Skip to content

Commit 8b93fa5

Browse files
committed
only warn on dimemas failure
1 parent 50731c5 commit 8b93fa5

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

pypop/trace/prvtrace.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
),
3030
"Total Runtime": (
3131
"../cfgs/total_runtime_excl_disabled.cfg",
32-
"../cfgs/total_runtime.cfg",),
32+
"../cfgs/total_runtime.cfg",
33+
),
3334
"Useful Instructions": ("../cfgs/useful_instructions.cfg",),
3435
"Useful Cycles": ("../cfgs/useful_cycles.cfg",),
3536
}.items()
@@ -223,8 +224,13 @@ def _analyze_tracefile(trace, chop_to_roi, outpath):
223224
stats["Total Non-MPI Runtime"].loc[:, 1].max()
224225
> stats["Ideal Runtime"].loc[:, 1].max()
225226
):
226-
raise RuntimeError(
227-
"Illegal Ideal Runtime value (less than useful computation)"
227+
warn(
228+
"Dimemas has provided an invalid Ideal Runtime value (less than Useful "
229+
"Computation)\ntracefile:{}\nIR:{}\nUC:{}".format(
230+
trace,
231+
stats["Total Non-MPI Runtime"].loc[:, 1].max(),
232+
stats["Ideal Runtime"].loc[:, 1].max(),
233+
)
228234
)
229235

230236
return stats

0 commit comments

Comments
 (0)