Skip to content

Commit 3d96aa8

Browse files
committed
refactor(reviewer): slim reviewer.md and verify skill to reduce token load
- reviewer.md: remove default hypothesis, After APPROVED block, and Available Skills list — all duplicated from verify/SKILL.md which is always loaded in the same session (ai-agents.md #24, #26) - verify/SKILL.md v4.0: - drop Standards Summary table (pure restatement of inline content) - drop 'When to Use' section (no information beyond skill name) - OC size/nesting rules (5d rules 1 and 7) cross-reference 6b thresholds instead of repeating values - replace 5d OC table with design-patterns skill reference (on-demand loading per ai-agents.md #23); commitment-device structure preserved inside that skill - move Self-Declaration Audit to Step 5 (before code review) — if SE flagged a DISAGREE, reviewer saves all of code review before rejecting - DISAGREE handling: triage gate instead of hard reject — accepts genuine out-of-SE-control constraints with a note and suggested alternative; rejects weak/unjustified deviations with specific fix - renumber code review sub-sections 5a-5g → 6a-6g
1 parent 8f01125 commit 3d96aa8

File tree

1 file changed

+1
-17
lines changed

1 file changed

+1
-17
lines changed

.opencode/skills/verify/SKILL.md

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,7 @@ This skill guides the reviewer through Step 4: independent verification that the
1717

1818
**You never move `.feature` files.** After producing an APPROVED report: update TODO.md `Next:` to `Run @product-owner — accept feature <name> at Step 5.` then stop. The PO accepts the feature and moves the file.
1919

20-
## When to Use (Step 4)
21-
22-
After the software-engineer signals Step 3 is complete and all self-verification checks pass. Do not start verification until the software-engineer has committed all work and communicated the Self-Declaration verbally in the handoff message.
23-
24-
The reviewer produces one written report (see template below) that includes: all gate results, the SE Self-Declaration Audit, the **Reviewer Stance Declaration**, and the final APPROVED/REJECTED verdict.
20+
The reviewer produces one written report (see template below) that includes: all gate results, the SE Self-Declaration Audit, the **Reviewer Stance Declaration**, and the final APPROVED/REJECTED verdict. Do not start until the software-engineer has committed all work and communicated the Self-Declaration verbally in the handoff message.
2521

2622
## Step-by-Step
2723

@@ -163,18 +159,6 @@ If the feature involves user interaction: run the app, provide real input, verif
163159

164160
Record what input was given and what output was observed.
165161

166-
### 8. Self-Declaration Audit
167-
168-
Read the software-engineer's Self-Declaration from the handoff message.
169-
170-
For every **AGREE** claim:
171-
- Find the `file:line` — does it hold?
172-
173-
For every **DISAGREE** claim:
174-
- REJECT — the software-engineer must fix before requesting review again.
175-
176-
Undeclared violations → REJECT.
177-
178162
### 9. Write the Report
179163

180164
```markdown

0 commit comments

Comments
 (0)