test: move development setup for packages to Ember 4

mdeanjones · mdeanjones · commit 4dbb6f930713 · 2022-06-17T09:18:42.000-04:00
diff --git a/packages/@nsf-open/ember-contact-utils/addon/computed-macros.ts b/packages/@nsf-open/ember-contact-utils/addon/computed-macros.ts
@@ -1,7 +1,6 @@
 import { computed, get } from '@ember/object';
 import { toDomesticUSPhoneNumber } from './formatters';
 
-
 /**
  * Exposes the `toDomesticUSPhoneNumber` formatter as an Ember computed decorator that normalizes a
  * string or number into a standard US telephone number with area code.
@@ -13,8 +12,8 @@ import { toDomesticUSPhoneNumber } from './formatters';
  * public formattedPhone!: string; // => "(123) 456-7890"
  * ```
  */
-export function domesticUSPhoneNumber(dependantKey: string, defaultValue = 'None') {
-	return computed(dependantKey, function computedDomesticUSPhoneNumber() {
+export function domesticUSPhoneNumber(dependantKey: string, defaultValue = 'None'): PropertyDecorator {
+	return computed<string, never>(dependantKey, function computedDomesticUSPhoneNumber() {
 		return toDomesticUSPhoneNumber(get(this, dependantKey), defaultValue);
 	});
 }
diff --git a/packages/@nsf-open/ember-contact-utils/addon/formatters.ts b/packages/@nsf-open/ember-contact-utils/addon/formatters.ts
@@ -1,5 +1,5 @@
 /** Strips special characters, leaving a string of digits. */
-function normalizePhoneNumber(value: any) {
+function normalizePhoneNumber(value: unknown) {
 	return typeof value === 'string'
 		? value.replace(/[\s()-.+]/g, '').trim()
 		: (typeof value === 'number' ? value.toString(10) : undefined);
@@ -20,7 +20,7 @@ function normalizePhoneNumber(value: any) {
  * toDomesticUSPhoneNumber("1234", "N/A"); // => "N/A"
  * ```
  */
-export function toDomesticUSPhoneNumber(value: any, defaultValue = 'None'): string {
+export function toDomesticUSPhoneNumber(value: unknown, defaultValue = 'None'): string {
 	const normalized = normalizePhoneNumber(value);
 
 	if (normalized) {
diff --git a/packages/@nsf-open/ember-contact-utils/package.json b/packages/@nsf-open/ember-contact-utils/package.json
@@ -59,10 +59,10 @@
     "@typescript-eslint/eslint-plugin": "^5.28.0",
     "@typescript-eslint/parser": "^5.28.0",
     "broccoli-asset-rev": "3.0.0",
+    "ember-auto-import": "^2.4.2",
     "ember-cli": "4.3.0",
     "ember-cli-code-coverage": "1.0.3",
     "ember-cli-dependency-checker": "3.3.1",
-    "ember-cli-eslint": "5.1.0",
     "ember-cli-htmlbars": "6.0.1",
     "ember-cli-inject-live-reload": "2.1.0",
     "ember-cli-sri": "2.1.1",
@@ -74,7 +74,7 @@
     "ember-maybe-import-regenerator": "1.0.0",
     "ember-qunit": "5.1.5",
     "ember-resolver": "8.0.3",
-    "ember-source": "3.28.9",
+    "ember-source": "^4.4.0",
     "ember-source-channel-url": "3.0.0",
     "ember-try": "2.0.0",
     "eslint": "^8.17.0",
@@ -84,7 +84,8 @@
     "qunit": "2.19.1",
     "typedoc": "0.22.15",
     "typedoc-plugin-markdown": "3.12.1",
-    "typescript": "4.6.4"
+    "typescript": "4.6.4",
+    "webpack": "^5.73.0"
   },
   "engines": {
     "node": ">= 10.*"
diff --git a/packages/@nsf-open/ember-currency-utils/package.json b/packages/@nsf-open/ember-currency-utils/package.json
@@ -59,10 +59,10 @@
     "@typescript-eslint/eslint-plugin": "^5.28.0",
     "@typescript-eslint/parser": "^5.28.0",
     "broccoli-asset-rev": "3.0.0",
+    "ember-auto-import": "^2.4.2",
     "ember-cli": "4.3.0",
     "ember-cli-code-coverage": "1.0.3",
     "ember-cli-dependency-checker": "3.3.1",
-    "ember-cli-eslint": "5.1.0",
     "ember-cli-htmlbars": "6.0.1",
     "ember-cli-inject-live-reload": "2.1.0",
     "ember-cli-sri": "2.1.1",
@@ -74,7 +74,7 @@
     "ember-maybe-import-regenerator": "1.0.0",
     "ember-qunit": "5.1.5",
     "ember-resolver": "8.0.3",
-    "ember-source": "3.28.9",
+    "ember-source": "^4.4.0",
     "ember-source-channel-url": "3.0.0",
     "ember-try": "2.0.0",
     "eslint": "^8.17.0",
@@ -84,7 +84,8 @@
     "qunit": "2.19.1",
     "typedoc": "0.22.15",
     "typedoc-plugin-markdown": "3.12.1",
-    "typescript": "4.6.4"
+    "typescript": "4.6.4",
+    "webpack": "^5.73.0"
   },
   "engines": {
     "node": ">= 10.*"
diff --git a/packages/@nsf-open/ember-datetime-utils/package.json b/packages/@nsf-open/ember-datetime-utils/package.json
@@ -60,10 +60,10 @@
     "@typescript-eslint/eslint-plugin": "^5.28.0",
     "@typescript-eslint/parser": "^5.28.0",
     "broccoli-asset-rev": "3.0.0",
+    "ember-auto-import": "^2.4.2",
     "ember-cli": "4.3.0",
     "ember-cli-code-coverage": "1.0.3",
     "ember-cli-dependency-checker": "3.3.1",
-    "ember-cli-eslint": "5.1.0",
     "ember-cli-htmlbars": "6.0.1",
     "ember-cli-inject-live-reload": "2.1.0",
     "ember-cli-sri": "2.1.1",
@@ -75,7 +75,7 @@
     "ember-maybe-import-regenerator": "1.0.0",
     "ember-qunit": "5.1.5",
     "ember-resolver": "8.0.3",
-    "ember-source": "3.28.9",
+    "ember-source": "^4.4.0",
     "ember-source-channel-url": "3.0.0",
     "ember-try": "2.0.0",
     "eslint": "^8.17.0",
@@ -85,7 +85,8 @@
     "qunit": "2.19.1",
     "typedoc": "0.22.15",
     "typedoc-plugin-markdown": "3.12.1",
-    "typescript": "4.6.4"
+    "typescript": "4.6.4",
+    "webpack": "^5.73.0"
   },
   "engines": {
     "node": ">= 10.*"
diff --git a/packages/@nsf-open/ember-datetime-utils/tests/unit/parser-test.ts b/packages/@nsf-open/ember-datetime-utils/tests/unit/parser-test.ts
@@ -82,10 +82,10 @@ module('Unit | Utility | parseDateTime()', function(hooks) {
 		);
 
 		assert.strictEqual(
-		  moment(parseDateTime('01/02/3000 08:31:14')).format('MM/DD/YYYY'),
-      '01/02/3000',
-      'MM/DD/YYYY HH:mm:ss'
-    );
+			moment(parseDateTime('01/02/3000 08:31:14')).format('MM/DD/YYYY'),
+			'01/02/3000',
+			'MM/DD/YYYY HH:mm:ss'
+		);
 	});
 
 
diff --git a/packages/@nsf-open/ember-general-utils/package.json b/packages/@nsf-open/ember-general-utils/package.json
@@ -59,10 +59,10 @@
     "@typescript-eslint/eslint-plugin": "^5.28.0",
     "@typescript-eslint/parser": "^5.28.0",
     "broccoli-asset-rev": "3.0.0",
+    "ember-auto-import": "^2.4.2",
     "ember-cli": "4.3.0",
     "ember-cli-code-coverage": "1.0.3",
     "ember-cli-dependency-checker": "3.3.1",
-    "ember-cli-eslint": "5.1.0",
     "ember-cli-htmlbars": "6.0.1",
     "ember-cli-inject-live-reload": "2.1.0",
     "ember-cli-sri": "2.1.1",
@@ -74,7 +74,7 @@
     "ember-maybe-import-regenerator": "1.0.0",
     "ember-qunit": "5.1.5",
     "ember-resolver": "8.0.3",
-    "ember-source": "3.28.9",
+    "ember-source": "^4.4.0",
     "ember-source-channel-url": "3.0.0",
     "ember-try": "2.0.0",
     "eslint": "^8.17.0",
@@ -84,7 +84,8 @@
     "qunit": "2.19.1",
     "typedoc": "0.22.15",
     "typedoc-plugin-markdown": "3.12.1",
-    "typescript": "4.6.4"
+    "typescript": "4.6.4",
+    "webpack": "^5.73.0"
   },
   "engines": {
     "node": ">= 10.*"
diff --git a/packages/@nsf-open/ember-general-utils/tests/integration/helpers-test.ts b/packages/@nsf-open/ember-general-utils/tests/integration/helpers-test.ts
@@ -1,3 +1,4 @@
+/* eslint-disable ember/no-get */
 import { module, test } from 'qunit';
 import { setupRenderingTest } from 'ember-qunit';
 import { render } from '@ember/test-helpers';
diff --git a/packages/@nsf-open/ember-general-utils/tests/unit/arrays-test.ts b/packages/@nsf-open/ember-general-utils/tests/unit/arrays-test.ts
@@ -8,11 +8,11 @@ module('Unit | Utility | arrays', function(hooks) {
 
 
 	test('intersection()', function(assert) {
-		// @ts-expect-error
+		// @ts-expect-error - purposefully providing an invalid argument
 		assert.deepEqual(intersection(null, null), []);
-		// @ts-expect-error
+		// @ts-expect-error - purposefully providing an invalid argument
 		assert.deepEqual(intersection([], null), []);
-		// @ts-expect-error
+		// @ts-expect-error - purposefully providing an invalid argument
 		assert.deepEqual(intersection(null, []), []);
 
 		assert.deepEqual(intersection([], []), []);
diff --git a/packages/@nsf-open/ember-general-utils/tests/unit/objects-test.ts b/packages/@nsf-open/ember-general-utils/tests/unit/objects-test.ts
@@ -56,10 +56,10 @@ module('Unit | Utility | objects', function(hooks) {
 		assert.strictEqual(isPromiseLike([]), false);
 
 		assert.strictEqual(isPromiseLike(Promise.resolve()), true);
-		assert.strictEqual(isPromiseLike({ then() {} }), true);
+		assert.strictEqual(isPromiseLike({ then() { /* noop */ } }), true);
 
-		const testFn = function() {};
-		testFn.then  = function() {};
+		const testFn = function() { /* noop */ };
+		testFn.then  = function() { /* noop */ };
 
 		assert.strictEqual(isPromiseLike(testFn), true);
 	});
diff --git a/packages/@nsf-open/ember-general-utils/tests/unit/strings-test.ts b/packages/@nsf-open/ember-general-utils/tests/unit/strings-test.ts
@@ -14,7 +14,7 @@ module('Unit | Utility | strings', function(hooks) {
 
 
 	test('truncate()', function(assert) {
-		// @ts-expect-error
+		// @ts-expect-error - purposefully providing an invalid argument
 		assert.throws(() => truncate(null));
 
 		assert.strictEqual(
@@ -50,7 +50,7 @@ module('Unit | Utility | strings', function(hooks) {
 
 
 	test('humanize()', function(assert) {
-		// @ts-expect-error
+		// @ts-expect-error - purposefully providing an invalid argument
 		assert.throws(() => humanize(null));
 
 		assert.strictEqual(humanize('fooBarBaz'),   'Foo bar baz');
diff --git a/packages/@nsf-open/ember-username-utils/package.json b/packages/@nsf-open/ember-username-utils/package.json
@@ -59,10 +59,10 @@
     "@typescript-eslint/eslint-plugin": "^5.28.0",
     "@typescript-eslint/parser": "^5.28.0",
     "broccoli-asset-rev": "3.0.0",
+    "ember-auto-import": "^2.4.2",
     "ember-cli": "4.3.0",
     "ember-cli-code-coverage": "1.0.3",
     "ember-cli-dependency-checker": "3.3.1",
-    "ember-cli-eslint": "5.1.0",
     "ember-cli-htmlbars": "6.0.1",
     "ember-cli-inject-live-reload": "2.1.0",
     "ember-cli-sri": "2.1.1",
@@ -74,7 +74,7 @@
     "ember-maybe-import-regenerator": "1.0.0",
     "ember-qunit": "5.1.5",
     "ember-resolver": "8.0.3",
-    "ember-source": "3.28.9",
+    "ember-source": "^4.4.0",
     "ember-source-channel-url": "3.0.0",
     "ember-try": "2.0.0",
     "eslint": "^8.17.0",
@@ -84,7 +84,8 @@
     "qunit": "2.19.1",
     "typedoc": "0.22.15",
     "typedoc-plugin-markdown": "3.12.1",
-    "typescript": "4.6.4"
+    "typescript": "4.6.4",
+    "webpack": "^5.73.0"
   },
   "engines": {
     "node": ">= 10.*"
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+/* eslint-disable ember/no-get */`
`1`	`2`	`import { module, test } from 'qunit';`
`2`	`3`	`import { setupRenderingTest } from 'ember-qunit';`
`3`	`4`	`import { render } from '@ember/test-helpers';`