From 3a34dd8fdbe157fadecc794cd4f7b0ca7a17091e Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Wed, 2 Sep 2026 14:05:14 +0200 Subject: [PATCH] build: derive V8_LOGGING_LEVEL from dcheck_always_on Signed-off-by: Joyee Cheung --- tools/v8_gypfiles/features.gypi | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tools/v8_gypfiles/features.gypi b/tools/v8_gypfiles/features.gypi index d656c7492dec..3f51d3da0044 100644 --- a/tools/v8_gypfiles/features.gypi +++ b/tools/v8_gypfiles/features.gypi @@ -461,9 +461,21 @@ 'defines': ['V8_ENABLE_SEEDED_ARRAY_INDEX_HASH',], }], ['dcheck_always_on!=0', { - 'defines': ['DEBUG',], + 'defines': [ + 'DEBUG', + 'V8_LOGGING_LEVEL=2', # Print file, line, message on fatal checks + ], }, { 'defines': ['NDEBUG',], + 'configurations': { + 'Debug': { + 'defines': ['V8_LOGGING_LEVEL=2',], + }, + 'Release': { + # Only log message (without file or line) on fatal checks + 'defines': ['V8_LOGGING_LEVEL=1',], + }, + }, }], ['v8_enable_verify_csa==1', { 'defines': ['ENABLE_VERIFY_CSA',],