From 869074ab15d30415e37e1bff404f093f626d182a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 4 Dec 2024 11:55:11 +0100 Subject: [PATCH] tools: improve release proposal PR opening - Open as draft. The releaser should review the PR and mark it as ready. - Add the "release" label. - Assign the releaser to the PR so it's clearer who's in charge and they can find it more easily. This will also notify and subscribe them to the PR. --- .github/workflows/create-release-proposal.yml | 3 ++- tools/actions/create-release.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/create-release-proposal.yml b/.github/workflows/create-release-proposal.yml index 6155b5da75f17b..8d19febe6f11c0 100644 --- a/.github/workflows/create-release-proposal.yml +++ b/.github/workflows/create-release-proposal.yml @@ -32,6 +32,7 @@ jobs: RELEASE_BRANCH: v${{ inputs.release-line }}.x RELEASE_DATE: ${{ inputs.release-date }} RELEASE_LINE: ${{ inputs.release-line }} + RELEASER: ${{ github.actor }} runs-on: ubuntu-latest steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 @@ -79,6 +80,6 @@ jobs: - name: Start git node release prepare run: | - ./tools/actions/create-release.sh "${RELEASE_DATE}" "${RELEASE_LINE}" + ./tools/actions/create-release.sh "${RELEASE_DATE}" "${RELEASE_LINE}" "${RELEASER}" env: GH_TOKEN: ${{ secrets.GH_USER_TOKEN }} diff --git a/tools/actions/create-release.sh b/tools/actions/create-release.sh index 3a69b3f5602ffc..1680f229b00854 100755 --- a/tools/actions/create-release.sh +++ b/tools/actions/create-release.sh @@ -4,6 +4,7 @@ set -xe RELEASE_DATE=$1 RELEASE_LINE=$2 +RELEASER=$3 if [ -z "$RELEASE_DATE" ] || [ -z "$RELEASE_LINE" ]; then echo "Usage: $0 " @@ -21,7 +22,7 @@ TITLE=$(awk "/^## ${RELEASE_DATE}/ { print substr(\$0, 4) }" "doc/changelogs/CHA # Use a temporary file for the PR body TEMP_BODY="$(awk "/## ${RELEASE_DATE}/,/^