Skip to content

Commit 45e37d9

Browse files
authored
build,tools: fix addon build deadlock on errors
PR-URL: #61321 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 0f15923 commit 45e37d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/build_addons.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ def node_gyp_rebuild(test_dir):
5858

5959
# We buffer the output and print it out once the process is done in order
6060
# to avoid interleaved output from multiple builds running at once.
61-
return_code = process.wait()
6261
stdout, stderr = process.communicate()
62+
return_code = process.returncode
6363
if return_code != 0:
6464
print(f'Failed to build addon in {test_dir}:')
6565
if stdout:

0 commit comments

Comments
 (0)