http-proxy-middleware comments

bourgeoa · bourgeoa · commit b278bffbe6b8 · 2025-12-28T00:25:36.000+01:00
diff --git a/lib/handlers/auth-proxy.mjs b/lib/handlers/auth-proxy.mjs
@@ -6,7 +6,7 @@ import debug from '../debug.mjs'
 import allow from './allow.mjs'
 
 const PROXY_SETTINGS = {
-  changeOrigin: true
+  changeOrigin: true // Default settings; target is provided per-proxy via function parameter
 }
 const REQUIRED_PERMISSIONS = {
   get: ['Read'],
diff --git a/lib/handlers/cors-proxy.mjs b/lib/handlers/cors-proxy.mjs
@@ -14,7 +14,7 @@ const CORS_SETTINGS = {
   origin: true
 }
 const PROXY_SETTINGS = {
-  target: 'http://placeholder',
+  target: 'http://placeholder', // Placeholder required by v3; actual target determined by router function
   changeOrigin: true,
   followRedirects: true,
   proxyTimeout: 10000,

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ import debug from '../debug.mjs'`
`6`	`6`	`import allow from './allow.mjs'`
`7`	`7`
`8`	`8`	`const PROXY_SETTINGS = {`
`9`		`- changeOrigin: true`
	`9`	`+ changeOrigin: true // Default settings; target is provided per-proxy via function parameter`
`10`	`10`	`}`
`11`	`11`	`const REQUIRED_PERMISSIONS = {`
`12`	`12`	`get: ['Read'],`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ const CORS_SETTINGS = {`
`14`	`14`	`origin: true`
`15`	`15`	`}`
`16`	`16`	`const PROXY_SETTINGS = {`
`17`		`- target: 'http://placeholder',`
	`17`	`+ target: 'http://placeholder', // Placeholder required by v3; actual target determined by router function`
`18`	`18`	`changeOrigin: true,`
`19`	`19`	`followRedirects: true,`
`20`	`20`	`proxyTimeout: 10000,`