[single] Refactor invoke_thread to remove goto statements

Refactor invoke_thread to remove goto statements and simplify control flow

Signed-off-by: hyunil park <hyunil46.park@samsung.com>

Author: songgot

c/src/ml-api-inference-single.c

@@ -495,22 +495,19 @@ __process_output (ml_single * single_h, ml_tensors_data_h output)
 static void *
 invoke_thread (void *arg)
 {
-  ml_single *single_h;
+  ml_single *single_h = (ml_single *) arg;
   ml_tensors_data_h input, output;
   gboolean alloc_output = FALSE;
-
-  single_h = (ml_single *) arg;
+  int status;
 
   g_mutex_lock (&single_h->mutex);
 
-  while (single_h->state <= RUNNING) {
-    int status = ML_ERROR_NONE;
-
+  while (TRUE) {
     /** wait for data */
     while (single_h->state != RUNNING) {
-      g_cond_wait (&single_h->cond, &single_h->mutex);
       if (single_h->state == JOIN_REQUESTED)
-        goto exit;
+        goto exit_thread;
+      g_cond_wait (&single_h->cond, &single_h->mutex);
     }
 
     input = single_h->input;
@@ -526,34 +523,34 @@ invoke_thread (void *arg)
     /* Clear input data after invoke is done. */
     ml_tensors_data_destroy (input);
     single_h->invoking = FALSE;
+    single_h->status = status;
 
     if (status != ML_ERROR_NONE || single_h->state == JOIN_REQUESTED) {
+      /* If error occurred or join requested during invocation */
       if (alloc_output) {
         single_h->destroy_data_list =
             g_list_remove (single_h->destroy_data_list, output);
         ml_tensors_data_destroy (output);
       }
-
+      /* If join requested, exit immediately without broadcast */
       if (single_h->state == JOIN_REQUESTED)
-        goto exit;
-      goto wait_for_next;
+        goto exit_thread;
+    } else {
+      /* Process output data on success */
+      if (alloc_output)
+        __process_output (single_h, output);
     }
 
-    if (alloc_output)
-      __process_output (single_h, output);
-
-    /** loop over to wait for the next element */
-  wait_for_next:
-    single_h->status = status;
+    /*Reset state and notify */
     if (single_h->state == RUNNING)
       single_h->state = IDLE;
+
     g_cond_broadcast (&single_h->cond);
   }
 
-exit:
-  /* Do not set IDLE if JOIN_REQUESTED */
+exit_thread:
+  /* Cleanup resources on exit */
   if (single_h->state == JOIN_REQUESTED) {
-    /* Release input and output data */
     if (single_h->input)
       ml_tensors_data_destroy (single_h->input);
 
@@ -562,10 +559,11 @@ invoke_thread (void *arg)
           g_list_remove (single_h->destroy_data_list, single_h->output);
       ml_tensors_data_destroy (single_h->output);
     }
-
     single_h->input = single_h->output = NULL;
-  } else if (single_h->state == RUNNING)
+  } else if (single_h->state == RUNNING) {
     single_h->state = IDLE;
+  }
+
   g_mutex_unlock (&single_h->mutex);
   return NULL;
 }