Skip to content

Allow for relative, up to 5% differences, while comparing numerics for fieldmap correspondence #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yarikoptic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow for relative, up to 5% differences, while comparing numerics for fieldmap correspondence #842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion heudiconv/bids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,9 @@ def find_compatible_fmaps_for_run(
else:
# allow for tiny differences between the affines etc
compatible = all(
np.allclose(x, y) for x, y in zip(json_info[param], fm_info)
# allow for small up to 5% difference
np.allclose(x, y, rtol=0.05)
for x, y in zip(json_info[param], fm_info)
)
if not compatible:
continue # don't bother checking more params
Expand Down
Loading