chore: apply review - 1

jung-han · jung-han · commit 21f6acbddf39 · 2019-07-08T14:37:59.000+09:00
diff --git a/README.md b/README.md
@@ -227,7 +227,6 @@ const MyComponent = () => (
   <Grid 
     columns={columns} 
     data={dataSource} 
-    pagination={true} 
     pageOptions={{perPage: 3}}
   />
 );
diff --git a/src/index.js b/src/index.js
@@ -18,7 +18,7 @@ export default class Grid extends React.Component {
       .filter((key) => /on[A-Z][a-zA-Z]+/.test(key))
       .forEach((key) => {
         const eventName = key[2].toLowerCase() + key.slice(3);
-        if (prevProps && prevProps[eventName] === props[eventName]) {
+        if (prevProps && prevProps[key] === props[key]) {
           this.gridInst.off(eventName);
         }
         this.gridInst.on(eventName, props[key]);

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ export default class Grid extends React.Component {`
`18`	`18`	`.filter((key) => /on[A-Z][a-zA-Z]+/.test(key))`
`19`	`19`	`.forEach((key) => {`
`20`	`20`	`const eventName = key[2].toLowerCase() + key.slice(3);`
`21`		`- if (prevProps && prevProps[eventName] === props[eventName]) {`
	`21`	`+ if (prevProps && prevProps[key] === props[key]) {`
`22`	`22`	`this.gridInst.off(eventName);`
`23`	`23`	`}`
`24`	`24`	`this.gridInst.on(eventName, props[key]);`