Obsolete Environment.Properties

Author: hazzik

src/NHibernate/Cfg/Configuration.cs

@@ -171,7 +171,9 @@ protected void Reset()
 			propertyReferences = new List<Mappings.PropertyReference>();
 			FilterDefinitions = new Dictionary<string, FilterDefinition>();
 			interceptor = EmptyInterceptor.Instance;
+#pragma warning disable 618
 			properties = Environment.Properties;
+#pragma warning restore 618
 			auxiliaryDatabaseObjects = new List<IAuxiliaryDatabaseObject>();
 			SqlFunctions = new Dictionary<string, ISQLFunction>();
 			mappingsQueue = new MappingsQueue();

src/NHibernate/Cfg/Environment.cs

@@ -383,6 +383,8 @@ private static IHibernateConfiguration GetHibernateConfiguration()
 		/// <remarks>
 		/// This is the replacement for hibernate.properties
 		/// </remarks>
+		//Since v5.3
+		[Obsolete("This property is not used and will be removed in a future version.")]
 		public static IDictionary<string, string> Properties
 		{
 			get { return new Dictionary<string, string>(GlobalProperties); }

src/NHibernate/Dialect/Dialect.cs

@@ -148,15 +148,18 @@ protected Dialect()
 		public static Dialect GetDialect()
 		{
 			string dialectName;
+#pragma warning disable 618
+			var properties = Environment.Properties;
+#pragma warning restore 618
 			try
 			{
-				dialectName = Environment.Properties[Environment.Dialect];
+				dialectName = properties[Environment.Dialect];
 			}
 			catch (Exception e)
 			{
 				throw new HibernateException("The dialect was not set. Set the property 'dialect'.", e);
 			}
-			return InstantiateDialect(dialectName, Environment.Properties);
+			return InstantiateDialect(dialectName, properties);
 		}
 
 		/// <summary>

src/NHibernate/Driver/DriverExtensions.cs

@@ -20,7 +20,9 @@ internal static int GetCommandTimeout(this IDriver driver)
 			if (driver is DriverBase driverBase)
 				return driverBase.CommandTimeout;
 
+#pragma warning disable 618
 			return PropertiesHelper.GetInt32(Cfg.Environment.CommandTimeout, Cfg.Environment.Properties, -1);
+#pragma warning restore 618
 		}
 
 		// 6.0 TODO: merge into IDriver