Failing test for NH3570.

One test for unidirectional onetomany and one test for bidirectional onetomany - both fails.

Author: RogerKratz

src/NHibernate.Test/NHSpecificTest/NH3570/BiFixture.cs

@@ -0,0 +1,51 @@
+using System;
+using NUnit.Framework;
+using SharpTestsEx;
+
+namespace NHibernate.Test.NHSpecificTest.NH3570
+{
+	[TestFixture]
+	public class BiFixture : BugTestCase
+	{
+		private Guid id;
+
+		[Test]
+		[KnownBug("NH-3570")]
+		public void ShouldNotSaveRemoveChild()
+		{
+			var parent = new BiParent();
+			parent.AddChild(new BiChild());
+			using (var s = OpenSession())
+			{
+				using (var tx = s.BeginTransaction())
+				{
+					id = (Guid)s.Save(parent);
+					parent.Children.Clear();
+					parent.AddChild(new BiChild());
+					tx.Commit();
+				}
+			}
+			using (var s = OpenSession())
+			{
+				using (s.BeginTransaction())
+				{
+					s.Get<BiParent>(id).Children.Count.Should().Be.EqualTo(1);
+					s.CreateCriteria<BiChild>().List().Count.Should().Be.EqualTo(1);
+				}
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var s = OpenSession())
+			{
+				using (var tx = s.BeginTransaction())
+				{
+					s.CreateQuery("delete from BiChild").ExecuteUpdate();
+					s.CreateQuery("delete from BiParent").ExecuteUpdate();
+					tx.Commit();
+				}
+			}
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH3570/Mappings.hbm.xml

@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test" namespace="NHibernate.Test.NHSpecificTest.NH3570">
+	<class name="UniParent">
+		<id name="Id">
+			<generator class="guid.comb" />
+		</id>
+		<version name="Version"/>
+		<bag name="Children" cascade="all-delete-orphan">
+			<key column="parentId"/>
+			<one-to-many class="UniChild"/>
+		</bag>
+	</class>
+	<class name="UniChild">
+		<id name="Id">
+			<generator class="guid.comb" />
+		</id>
+	</class>
+
+	<class name="BiParent">
+		<id name="Id">
+			<generator class="guid.comb" />
+		</id>
+		<version name="Version"/>
+		<bag name="Children" cascade="all-delete-orphan" inverse="true">
+			<key column="parentId"/>
+			<one-to-many class="BiChild"/>
+		</bag>
+	</class>
+	<class name="BiChild">
+		<id name="Id">
+			<generator class="guid.comb" />
+		</id>
+		<many-to-one class="BiParent" name="Parent" column="parentId"/>
+	</class>
+</hibernate-mapping>
+

src/NHibernate.Test/NHSpecificTest/NH3570/Model.cs

@@ -0,0 +1,46 @@
+using System;
+using System.Collections.Generic;
+
+namespace NHibernate.Test.NHSpecificTest.NH3570
+{
+	public class UniParent
+	{
+		public UniParent()
+		{
+			Children = new List<UniChild>();
+		}
+
+		public virtual Guid Id { get; set; }
+		public virtual IList<UniChild> Children { get; set; }
+		public virtual int Version { get; set; }
+	}
+
+	public class UniChild
+	{
+		public virtual Guid Id { get; set; }
+	}
+
+	public class BiParent
+	{
+		public BiParent()
+		{
+			Children = new List<BiChild>();
+		}
+
+		public virtual Guid Id { get; set; }
+		public virtual IList<BiChild> Children { get; set; }
+		public virtual int Version { get; set; }
+		
+		public virtual void AddChild(BiChild child)
+		{
+			child.Parent = this;
+			Children.Add(child);
+		}
+	}
+
+	public class BiChild
+	{
+		public virtual Guid Id { get; set; }
+		public virtual BiParent Parent { get; set; }
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH3570/UniFixture.cs

@@ -0,0 +1,51 @@
+using System;
+using NUnit.Framework;
+using SharpTestsEx;
+
+namespace NHibernate.Test.NHSpecificTest.NH3570
+{
+	[TestFixture]
+	public class UniFixture : BugTestCase
+	{
+		private Guid id;
+
+		[Test]
+		[KnownBug("NH-3570")]
+		public void ShouldNotSaveRemoveChild()
+		{
+			var parent = new UniParent();
+			parent.Children.Add(new UniChild());
+			using (var s = OpenSession())
+			{
+				using (var tx = s.BeginTransaction())
+				{
+					id = (Guid) s.Save(parent);
+					parent.Children.Clear();
+					parent.Children.Add(new UniChild());
+					tx.Commit();
+				}
+			}
+			using (var s = OpenSession())
+			{
+				using (s.BeginTransaction())
+				{
+					s.Get<UniParent>(id).Children.Count.Should().Be.EqualTo(1);
+					s.CreateCriteria<UniChild>().List().Count.Should().Be.EqualTo(1);
+				}
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var s = OpenSession())
+			{
+				using (var tx = s.BeginTransaction())
+				{
+					s.CreateQuery("delete from UniChild").ExecuteUpdate();
+					s.CreateQuery("delete from UniParent").ExecuteUpdate();
+					tx.Commit();
+				}
+			}
+		}
+	}
+}

src/NHibernate.Test/NHibernate.Test.csproj

@@ -690,6 +690,9 @@
     <Compile Include="NHSpecificTest\BagWithLazyExtraAndFilter\Fixture.cs" />
     <Compile Include="Linq\ByMethod\DistinctTests.cs" />
     <Compile Include="Component\Basic\ComponentWithUniqueConstraintTests.cs" />
+    <Compile Include="NHSpecificTest\NH3570\BiFixture.cs" />
+    <Compile Include="NHSpecificTest\NH3570\Model.cs" />
+    <Compile Include="NHSpecificTest\NH3570\UniFixture.cs" />
     <Compile Include="NHSpecificTest\NH3620\Fixture.cs" />
     <Compile Include="NHSpecificTest\NH3620\TwoBlobs.cs" />
     <Compile Include="NHSpecificTest\NH3455\Address.cs" />
@@ -3054,6 +3057,7 @@
     <EmbeddedResource Include="NHSpecificTest\NH1291AnonExample\Mappings.hbm.xml" />
   </ItemGroup>
   <ItemGroup>
+    <EmbeddedResource Include="NHSpecificTest\NH3570\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3455\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3590\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3377\Mappings.hbm.xml" />