Obsolete StringHelper.Join

Author: bahusoid

src/NHibernate/Criterion/ConditionalProjection.cs

@@ -73,8 +73,8 @@ public override IType[] GetTypes(ICriteria criteria, ICriteriaQuery criteriaQuer
 			if(areEqual == false)
 			{
 				string msg = "Both true and false projections must return the same types."+ Environment.NewLine +
-				             "But True projection returns: ["+StringHelper.Join(", ", trueTypes) +"] "+ Environment.NewLine+
-				             "And False projection returns: ["+StringHelper.Join(", ", falseTypes)+ "]";
+				             "But True projection returns: ["+string.Join<IType>(", ", trueTypes) +"] "+ Environment.NewLine+
+				             "And False projection returns: ["+string.Join<IType>(", ", falseTypes)+ "]";
 
 				throw new HibernateException(msg);
 			}

src/NHibernate/Criterion/IdentifierProjection.cs

@@ -64,7 +64,7 @@ public override SqlString ToGroupSqlString(ICriteria criteria, ICriteriaQuery cr
 			{
 				throw new InvalidOperationException("not a grouping projection");
 			}
-			return new SqlString(StringHelper.Join(",", criteriaQuery.GetIdentifierColumns(criteria)));
+			return new SqlString(string.Join(",", criteriaQuery.GetIdentifierColumns(criteria)));
 		}
 	}
 }

src/NHibernate/Criterion/Junction.cs

@@ -106,7 +106,7 @@ public override SqlString ToSqlString(ICriteria criteria, ICriteriaQuery criteri
 
 		public override string ToString()
 		{
-			return '(' + StringHelper.Join(Op, criteria) + ')';
+			return '(' + string.Join(Op, criteria) + ')';
 		}
 
 		public override IProjection[] GetProjections()

src/NHibernate/Criterion/PropertyProjection.cs

@@ -72,7 +72,7 @@ public override SqlString ToGroupSqlString(ICriteria criteria, ICriteriaQuery cr
 			{
 				throw new InvalidOperationException("not a grouping projection");
 			}
-			return new SqlString(StringHelper.Join(",", criteriaQuery.GetColumns(criteria, propertyName)));
+			return new SqlString(string.Join(",", criteriaQuery.GetColumns(criteria, propertyName)));
 		}
 	}
-}
+}

src/NHibernate/Dialect/InformixDialect.cs

@@ -441,14 +441,14 @@ public override string GetAddForeignKeyConstraintString(string constraintName, s
 			var res = new StringBuilder(200);
 
 			res.Append(" add constraint foreign key (")
-				.Append(StringHelper.Join(StringHelper.CommaSpace, foreignKey))
+				.Append(string.Join(StringHelper.CommaSpace, foreignKey))
 				.Append(") references ")
 				.Append(referencedTable);
 
 			if (!referencesPrimaryKey)
 			{
 				res.Append(" (")
-					.Append(StringHelper.Join(StringHelper.CommaSpace, primaryKey))
+					.Append(string.Join(StringHelper.CommaSpace, primaryKey))
 					.Append(')');
 			}
 

src/NHibernate/Dialect/MsSql2000Dialect.cs

@@ -788,7 +788,7 @@ public LockHintAppender(MsSql2000Dialect dialect, IDictionary<string, LockMode>
 
 				// Regex matching any alias out of those given. Aliases should contain
 				// no dangerous characters (they are identifiers) so they are not escaped.
-				var aliasesPattern = StringHelper.Join("|", aliasedLockModes.Keys);
+				var aliasesPattern = string.Join("|", aliasedLockModes.Keys);
 
 				// Match < alias >, < alias,>, or < alias$>, the intent is to capture alias names
 				// in various kinds of "FROM table1 alias1, table2 alias2".

src/NHibernate/Dialect/Oracle8iDialect.cs

@@ -389,7 +389,7 @@ private static string ExtractColumnOrAliasNames(SqlString select)
 			Dictionary<SqlString, SqlString> columnToAlias;
 			ExtractColumnOrAliasNames(select, out columnsOrAliases, out aliasToColumn, out columnToAlias);
 
-			return StringHelper.Join(",", columnsOrAliases);
+			return string.Join(",", columnsOrAliases);
 		}
 
 		/// <summary> 

src/NHibernate/Engine/SubselectFetch.cs

@@ -40,12 +40,12 @@ public SqlString ToSubselectString(string ukname)
 			                       	? StringHelper.Qualify(alias, loadable.IdentifierColumnNames)
 			                       	: ((IPropertyMapping) loadable).ToColumns(alias, ukname);
 
-			return new SqlString("select ", StringHelper.Join(", ", joinColumns), queryString);
+			return new SqlString("select ", string.Join(", ", joinColumns), queryString);
 		}
 
 		public override string ToString()
 		{
 			return "SubselectFetch(" + queryString + ')';
 		}
 	}
-}
+}

src/NHibernate/Hql/Ast/ANTLR/Exec/AbstractStatementExecutor.cs

@@ -143,7 +143,7 @@ private static SqlString GetWhereJoinFragment(IJoinable persister, string tableA
 
 		protected string GenerateIdSubselect(IQueryable persister)
 		{
-			return "select " + StringHelper.Join(", ", persister.IdentifierColumnNames) + " from " + persister.TemporaryIdTableName;
+			return "select " + string.Join(", ", persister.IdentifierColumnNames) + " from " + persister.TemporaryIdTableName;
 		}
 
 		protected virtual void CreateTemporaryTableIfNecessary(IQueryable persister, ISessionImplementor session)

src/NHibernate/Hql/Ast/ANTLR/Exec/MultiTableDeleteExecutor.cs

@@ -51,7 +51,7 @@ public MultiTableDeleteExecutor(IStatement statement)
 				//          defining all the needed attributes), then we could then get an array of those
 				SqlDeleteBuilder delete = new SqlDeleteBuilder(Factory.Dialect, Factory)
 					.SetTableName(tableNames[i])
-					.SetWhere("(" + StringHelper.Join(", ", columnNames[i]) + ") IN (" + idSubselect + ")");
+					.SetWhere("(" + string.Join(", ", columnNames[i]) + ") IN (" + idSubselect + ")");
 				if (Factory.Settings.IsCommentsEnabled)
 				{
 					delete.SetComment("bulk delete");