Fix a null ref exception in a flaky test.

Author: fredericDelaporte

src/NHibernate.Test/Async/NHSpecificTest/NH3634/FixtureByCode.cs

@@ -129,6 +129,7 @@ public async Task QueryOverComponentWithANullPropertyAsync()
 								   .Where(p => p.Connection == componentToCompare)
 								   .SingleOrDefaultAsync<Person>());
 
+				Assert.That(sally, Is.Not.Null);
 				Assert.That(sally.Name, Is.EqualTo("Sally"));
 				Assert.That(sally.Connection.PortName, Is.Null);
 			}
@@ -164,6 +165,7 @@ public async Task QueryAgainstComponentWithANullPropertyUsingCriteriaAsync()
 				                   .Add(Restrictions.Eq("Connection", componentToCompare))
 				                   .UniqueResultAsync<Person>());
 
+				Assert.That(sally, Is.Not.Null);
 				Assert.That(sally.Name, Is.EqualTo("Sally"));
 				Assert.That(sally.Connection.PortName, Is.Null);
 			}
@@ -187,6 +189,7 @@ public async Task CachedQueryMissesWithDifferentNotNullComponentAsync()
 								   .SetCacheable(true)
 								   .UniqueResultAsync<CachedPerson>());
 
+				Assert.That(cached, Is.Not.Null);
 				Assert.That(cached.Name, Is.EqualTo("CachedNull"));
 				Assert.That(cached.Connection.PortName, Is.Null);
 
@@ -234,6 +237,7 @@ public async Task CachedQueryMissesWithDifferentNullComponentAsync()
 								   .SetCacheable(true)
 								   .UniqueResultAsync<CachedPerson>());
 
+				Assert.That(cached, Is.Not.Null);
 				Assert.That(cached.Name, Is.EqualTo("CachedNotNull"));
 				Assert.That(cached.Connection.PortName, Is.Not.Null);
 
@@ -281,6 +285,7 @@ public async Task CachedQueryAgainstComponentWithANullPropertyUsingCriteriaAsync
 								   .SetCacheable(true)
 								   .UniqueResultAsync<CachedPerson>());
 
+				Assert.That(cached, Is.Not.Null);
 				Assert.That(cached.Name, Is.EqualTo("CachedNull"));
 				Assert.That(cached.Connection.PortName, Is.Null);
 
@@ -303,6 +308,7 @@ public async Task CachedQueryAgainstComponentWithANullPropertyUsingCriteriaAsync
 								   .SetCacheable(true)
 								   .UniqueResultAsync<CachedPerson>());
 
+				Assert.That(cached, Is.Not.Null);
 				Assert.That(cached.Name, Is.EqualTo("CachedNull"));
 				Assert.That(cached.Connection.PortName, Is.Null);
 
@@ -332,6 +338,7 @@ public async Task QueryOverANullComponentPropertyAsync()
 				                   .And(p => p.Connection.ConnectionType == "http")
 				                   .SingleOrDefaultAsync<Person>());
 
+				Assert.That(sally, Is.Not.Null);
 				Assert.That(sally.Name, Is.EqualTo("Sally"));
 				Assert.That(sally.Connection.PortName, Is.Null);
 			}
@@ -349,6 +356,7 @@ public async Task QueryAgainstANullComponentPropertyUsingCriteriaApiAsync()
 				                   .Add(Restrictions.Eq("Connection.ConnectionType", "http"))
 				                   .UniqueResultAsync<Person>());
 
+				Assert.That(sally, Is.Not.Null);
 				Assert.That(sally.Name, Is.EqualTo("Sally"));
 				Assert.That(sally.Connection.PortName, Is.Null);
 			}

src/NHibernate.Test/NHSpecificTest/NH3634/FixtureByCode.cs

@@ -118,6 +118,7 @@ public void QueryOverComponentWithANullProperty()
 								   .Where(p => p.Connection == componentToCompare)
 								   .SingleOrDefault<Person>();
 
+				Assert.That(sally, Is.Not.Null);
 				Assert.That(sally.Name, Is.EqualTo("Sally"));
 				Assert.That(sally.Connection.PortName, Is.Null);
 			}
@@ -153,6 +154,7 @@ public void QueryAgainstComponentWithANullPropertyUsingCriteria()
 				                   .Add(Restrictions.Eq("Connection", componentToCompare))
 				                   .UniqueResult<Person>();
 
+				Assert.That(sally, Is.Not.Null);
 				Assert.That(sally.Name, Is.EqualTo("Sally"));
 				Assert.That(sally.Connection.PortName, Is.Null);
 			}
@@ -176,6 +178,7 @@ public void CachedQueryMissesWithDifferentNotNullComponent()
 								   .SetCacheable(true)
 								   .UniqueResult<CachedPerson>();
 
+				Assert.That(cached, Is.Not.Null);
 				Assert.That(cached.Name, Is.EqualTo("CachedNull"));
 				Assert.That(cached.Connection.PortName, Is.Null);
 
@@ -223,6 +226,7 @@ public void CachedQueryMissesWithDifferentNullComponent()
 								   .SetCacheable(true)
 								   .UniqueResult<CachedPerson>();
 
+				Assert.That(cached, Is.Not.Null);
 				Assert.That(cached.Name, Is.EqualTo("CachedNotNull"));
 				Assert.That(cached.Connection.PortName, Is.Not.Null);
 
@@ -270,6 +274,7 @@ public void CachedQueryAgainstComponentWithANullPropertyUsingCriteria()
 								   .SetCacheable(true)
 								   .UniqueResult<CachedPerson>();
 
+				Assert.That(cached, Is.Not.Null);
 				Assert.That(cached.Name, Is.EqualTo("CachedNull"));
 				Assert.That(cached.Connection.PortName, Is.Null);
 
@@ -292,6 +297,7 @@ public void CachedQueryAgainstComponentWithANullPropertyUsingCriteria()
 								   .SetCacheable(true)
 								   .UniqueResult<CachedPerson>();
 
+				Assert.That(cached, Is.Not.Null);
 				Assert.That(cached.Name, Is.EqualTo("CachedNull"));
 				Assert.That(cached.Connection.PortName, Is.Null);
 
@@ -321,6 +327,7 @@ public void QueryOverANullComponentProperty()
 				                   .And(p => p.Connection.ConnectionType == "http")
 				                   .SingleOrDefault<Person>();
 
+				Assert.That(sally, Is.Not.Null);
 				Assert.That(sally.Name, Is.EqualTo("Sally"));
 				Assert.That(sally.Connection.PortName, Is.Null);
 			}
@@ -338,6 +345,7 @@ public void QueryAgainstANullComponentPropertyUsingCriteriaApi()
 				                   .Add(Restrictions.Eq("Connection.ConnectionType", "http"))
 				                   .UniqueResult<Person>();
 
+				Assert.That(sally, Is.Not.Null);
 				Assert.That(sally.Name, Is.EqualTo("Sally"));
 				Assert.That(sally.Connection.PortName, Is.Null);
 			}