Skip to content

Conversation

@sjberman
Copy link
Collaborator

@sjberman sjberman commented Dec 1, 2025

Problem: Saw an issue where nginx failed to connect to the control plane due to an empty hostname and not being able to find the pod name.

Solution: If ContainerInfo provided by agent is empty, fall back to HostInfo. This should cover all bases to ensure we get the hostname.

Testing: Fixed my issue that I saw locally.

Closes #4366

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Fixed an issue where control plane and data plane failed to connect due to empty pod name (hostname).

Problem: Saw an issue where nginx failed to connect to the control plane due to an empty hostname and not being able to find the pod name.

Solution: If ContainerInfo provided by agent is empty, fall back to HostInfo. This should cover all bases to ensure we get the hostname.
@sjberman sjberman requested a review from a team as a code owner December 1, 2025 18:59
@github-actions github-actions bot added the bug Something isn't working label Dec 1, 2025
@sjberman sjberman enabled auto-merge (squash) December 1, 2025 19:01
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (2a64f38) to head (a26a62d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4367      +/-   ##
==========================================
- Coverage   86.08%   86.08%   -0.01%     
==========================================
  Files         132      132              
  Lines       14342    14344       +2     
  Branches       35       35              
==========================================
+ Hits        12347    12348       +1     
- Misses       1791     1792       +1     
  Partials      204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman merged commit b88de84 into main Dec 1, 2025
60 of 61 checks passed
@sjberman sjberman deleted the bug/empty-hostname branch December 1, 2025 19:29
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

PodOwner not found with empty name

4 participants