Remove extra quotes (#326)

Author: alessfg

.travis.yml

@@ -6,58 +6,58 @@ branches:
     - main
 jobs:
   include:
-    - name: "(Debian/Ubuntu) Install Specific Version"
+    - name: (Debian/Ubuntu) Install specific version
       env:
         scenario: default
-    - name: "(Alpine Linux) Install Specific Version"
+    - name: (Alpine Linux) Install specific version
       env:
         scenario: default_alpine
-    - name: "(CentOS) Install Specific Version"
+    - name: (CentOS) Install specific version
       env:
         scenario: default_centos
-    - name: "(Debian/Ubuntu) Install Modules"
+    - name: (Debian/Ubuntu) Cleanup config and try to install modules
       env:
         scenario: module
-    - name: "(Alpine Linux) Install Modules"
+    - name: (Alpine Linux) Cleanup config and try to install modules
       env:
         scenario: module_alpine
-    - name: "(CentOS) Install Modules"
+    - name: (CentOS) Cleanup config and try to install modules
       env:
         scenario: module_centos
-    - name: "(Debian/Ubuntu) Install Stable Branch and Push Configuration"
+    - name: (Debian/Ubuntu) Install stable branch and push a config
       env:
         scenario: stable_push
-    - name: "(Alpine Linux) Install Stable Branch and Push Configuration"
+    - name: (Alpine Linux) Install stable branch and push a config
       env:
         scenario: stable_push_alpine
-    - name: "(CentOS) Install Stable Branch and Push Configuration"
+    - name: (CentOS) Install stable branch and push a config
       env:
         scenario: stable_push_centos
-    - name: "(Debian/Ubuntu) Use Template Setting"
+    - name: (Debian/Ubuntu) Test config templates
       env:
         scenario: template
-    - name: "(Alpine Linux) Use Template Setting"
+    - name: (Alpine Linux) Test config templates
       env:
         scenario: template_alpine
-    - name: "(CentOS) Use Template Setting"
+    - name: (CentOS) Test config templates
       env:
         scenario: template_centos
-    - name: "(Debian/Ubuntu) Install NGINX Unit"
+    - name: (Debian/Ubuntu) Install NGINX Unit
       env:
         scenario: unit
-    - name: "(Alpine Linux) Install NGINX Unit"
+    - name: (Alpine Linux) Install NGINX Unit
       env:
         scenario: unit_alpine
-    - name: "(CentOS) Install NGINX Unit"
+    - name: (CentOS) Install NGINX Unit
       env:
         scenario: unit_centos
-    - name: "(Debian/Ubuntu) Install from Source"
+    - name: (Debian/Ubuntu) Build from source
       env:
         scenario: source
-    - name: "(Alpine Linux) Install from Source"
+    - name: (Alpine Linux) Build from source
       env:
         scenario: source_alpine
-    - name: "(CentOS) Install from Source"
+    - name: (CentOS) Build from source
       env:
         scenario: source_centos
 before_install:

handlers/main.yml

@@ -1,22 +1,22 @@
 ---
-- name: "(Handler) Check NGINX"
-  command: "nginx -t"
+- name: (Handler) Check NGINX
+  command: nginx -t
   register: config
   ignore_errors: yes
-  listen: "(Handler) Run NGINX"
+  listen: (Handler) Run NGINX
 
-- name: "(Handler) Print NGINX error if syntax check fails"
+- name: (Handler) Print NGINX error if syntax check fails
   debug:
     var: config.stderr_lines
   failed_when: config.rc != 0
   when: config.rc != 0
-  listen: "(Handler) Run NGINX"
+  listen: (Handler) Run NGINX
 
-- name: "(Handler) Systemd daemon-reload"
+- name: (Handler) Systemd daemon-reload
   systemd:
     daemon_reload: yes
 
-- name: "(Handler) Start/Reload NGINX"
+- name: (Handler) Start/Reload NGINX
   service:
     name: nginx
     state: reloaded
@@ -26,22 +26,22 @@
     - not ansible_check_mode | bool
   listen: "(Handler) Run NGINX"
 
-- name: "(Handler) Start NGINX Amplify agent"
+- name: (Handler) Start NGINX Amplify agent
   service:
     name: amplify-agent
     state: started
 
-- name: "(DEPRECATED Handler: Debian/Ubuntu/CentOS/RedHat) Start NGINX Unit"
+- name: (DEPRECATED Handler - Debian/Ubuntu/CentOS/RedHat) Start NGINX Unit
   service:
     name: unit
     state: started
     enabled: yes
 
-- name: "(DEPRECATED Handler: FreeBSD) Start NGINX Unit"
+- name: (DEPRECATED Handler - FreeBSD) Start NGINX Unit
   service:
     name: unitd
     state: started
     enabled: yes
 
-- name: "(Handler) Run logrotate"
+- name: (Handler) Run logrotate
   command: logrotate -f /etc/logrotate.d/nginx

molecule/common/playbooks/default_converge.yml

@@ -36,7 +36,7 @@
         nginx_logrotate_conf_enable: true
         nginx_logrotate_conf:
           paths:
-            - "/var/log/nginx/*.log"
+            - /var/log/nginx/*.log
           options:
             - daily
             - missingok

tasks/amplify/install-amplify.yml

@@ -1,23 +1,23 @@
 ---
-- name: "Configure NGINX Amplify agent repository"
+- name: Configure NGINX Amplify agent repository
   include_tasks: "{{ role_path }}/tasks/amplify/setup-{{ ansible_facts['os_family'] | lower }}.yml"
   when: ansible_facts['os_family'] in ['Debian', 'RedHat']
 
-- name: "Install NGINX Amplify agent"
+- name: Install NGINX Amplify agent
   package:
     name: nginx-amplify-agent
     state: present
 
-- name: "Copy NGINX configurator agent configuration template"
+- name: Copy NGINX configurator agent configuration template
   copy:
     remote_src: yes
     src: /etc/amplify-agent/agent.conf.default
     dest: /etc/amplify-agent/agent.conf
     mode: 0644
 
-- name: "Configure NGINX Amplify agent API key"
+- name: Configure NGINX Amplify agent API key
   lineinfile:
     dest: /etc/amplify-agent/agent.conf
     regexp: api_key =.*
     line: "api_key = {{ nginx_amplify_api_key }}"
-  notify: "(Handler) Start NGINX Amplify agent"
+  notify: (Handler) Start NGINX Amplify agent

tasks/amplify/setup-debian.yml

@@ -1,5 +1,5 @@
 ---
-- name: "(Debian/Ubuntu) Add NGINX Amplify agent repository"
+- name: (Debian/Ubuntu) Add NGINX Amplify agent repository
   apt_repository:
     filename: nginx-amplify
     repo: "deb [arch=amd64] https://packages.amplify.nginx.com/{{ ansible_facts['distribution'] | lower }}/
@@ -8,7 +8,7 @@
     mode: 0644
   when: ansible_facts['distribution_release'] != "focal"
 
-- name: "(Ubuntu 20.04) Add NGINX Amplify agent repository"
+- name: (Ubuntu 20.04) Add NGINX Amplify agent repository
   apt_repository:
     filename: nginx-amplify
     repo: deb [arch=amd64] https://packages.amplify.nginx.com/py3/ubuntu focal amplify-agent

tasks/amplify/setup-redhat.yml

@@ -1,5 +1,5 @@
 ---
-- name: "(Amazon Linux/CentOS/RHEL) Add NGINX Amplify agent repository"
+- name: (Amazon Linux/CentOS/RHEL) Add NGINX Amplify agent repository
   yum_repository:
     name: nginx-amplify
     baseurl: http://packages.amplify.nginx.com/{{ (ansible_facts['distribution'] == "Amazon") | ternary('amzn/', 'centos/') }}/$releasever/$basearch/

tasks/config/cleanup-config.yml

@@ -1,10 +1,10 @@
 ## DEPRECATED -- Use nginxinc.nginx_config role instead (https://github.com/nginxinc/ansible-role-nginx-config)
 ---
-- name: "Deprecation warning"
+- name: Deprecation warning
   debug:
-    msg: "DEPRECATED TASKS -- Use nginxinc.nginx_config role instead (https://github.com/nginxinc/ansible-role-nginx-config)"
+    msg: DEPRECATED TASKS -- Use nginxinc.nginx_config role instead (https://github.com/nginxinc/ansible-role-nginx-config)
 
-- name: "(DEPRECATED) Find NGINX Configuration Files"
+- name: (DEPRECATED) Find NGINX Configuration Files
   find:
     paths: "{{ item.directory }}"
     patterns: "*.conf"
@@ -13,7 +13,7 @@
   when: nginx_cleanup_config_paths is defined
   register: nginx_config_files
 
-- name: "(DEPRECATED) Remove NGINX Configuration Files"
+- name: (DEPRECATED) Remove NGINX Configuration Files
   file:
     path: "{{ item }}"
     state: absent

tasks/config/debug-output.yml

@@ -1,9 +1,9 @@
 ---
-- name: "Register NGINX configuration"
-  command: "nginx -T"
+- name: Register NGINX config
+  command: nginx -T
   changed_when: false
   register: config
 
-- name: "Print NGINX config"
+- name: Print NGINX config
   debug:
     var: config.stdout_lines

tasks/config/modify-systemd.yml

@@ -1,11 +1,11 @@
 ---
-- name: "Create override directory for NGINX systemd service"
+- name: Create override directory for NGINX systemd service
   file:
     path: "{{ nginx_service_overridepath }}"
     state: directory
     mode: 0755
 
-- name: "Create override for NGINX systemd service"
+- name: Create override for NGINX systemd service
   template:
     src: "{{ role_path }}/templates/services/nginx.service.override.conf.j2"
     dest: "{{ nginx_service_overridepath }}/{{ nginx_service_overridefilename }}"
@@ -15,9 +15,9 @@
   when:
     - not nginx_service_custom | bool
     - not nginx_service_clean | bool
-  notify: "(Handler) Systemd daemon-reload"
+  notify: (Handler) Systemd daemon-reload
 
-- name: "Customize override for NGINX systemd service"
+- name: Customize override for NGINX systemd service
   copy:
     src: "{{ nginx_service_custom_file }}"
     dest: "{{ nginx_service_overridepath }}/{{ nginx_service_overridefilename }}"
@@ -27,11 +27,11 @@
   when:
     - nginx_service_custom | bool
     - not nginx_service_clean | bool
-  notify: "(Handler) Systemd daemon-reload"
+  notify: (Handler) Systemd daemon-reload
 
-- name: "Remove override for NGINX systemd service"
+- name: Remove override for NGINX systemd service
   file:
     path: "{{ nginx_service_overridepath }}"
     state: absent
   when: nginx_service_clean | bool
-  notify: "(Handler) Systemd daemon-reload"
+  notify: (Handler) Systemd daemon-reload

tasks/config/setup-logrotate.yml

@@ -1,36 +1,36 @@
 ---
-- name: "(Alpine Linux) Install logrotate"
+- name: (Alpine Linux) Install logrotate
   apk:
     name: logrotate
   when: ansible_facts['os_family'] == "Alpine"
 
-- name: "(Debian/Ubuntu) Install logrotate"
+- name: (Debian/Ubuntu) Install logrotate
   apt:
     name: logrotate
     state: present
   when: ansible_facts['os_family'] == "Debian"
 
-- name: "(Amazon Linux/CentOS/Oracle Linux/RHEL) Install logrotate"
+- name: (Amazon Linux/CentOS/Oracle Linux/RHEL) Install logrotate
   yum:
     name: logrotate
     state: present
   when: ansible_facts['os_family'] == "RedHat"
 
-- name: "(SLES) Set up logrotate"
+- name: (SLES) Set up logrotate
   block:
-    - name: "(SLES) Configure logrotate repository"
+    - name: (SLES) Configure logrotate repository
       zypper_repository:
         repo: https://download.opensuse.org/repositories/openSUSE:Leap:42.1/standard/openSUSE:Leap:42.1.repo
 
-    - name: "(SLES) Install Logrotate"
+    - name: (SLES) Install Logrotate
       zypper:
         name: logrotate
         state: present
   when: ansible_facts['os_family'] == "Suse"
 
-- name: "Create logrotate config"
+- name: Create logrotate config
   template:
-    src: "logrotate/nginx.j2"
-    dest: "/etc/logrotate.d/nginx"
+    src: logrotate/nginx.j2
+    dest: /etc/logrotate.d/nginx
     mode: 0644
-  notify: "(Handler) Run logrotate"
+  notify: (Handler) Run logrotate