From 2f04e5676f73c3a1e65edfc126054c55052457ae Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Wed, 6 May 2026 01:16:47 +0200 Subject: [PATCH] chore(appstore): remove legacy warnings for now required attributes `` is now a required element of the appinfo for quite a long time. So we can remove the legacy warning from owncloud times. Its validated with the XSD anyways. Signed-off-by: Ferdinand Thiessen --- apps/appstore/lib/Controller/ApiController.php | 9 ++------- apps/appstore/openapi.json | 10 +--------- apps/appstore/src/apps.d.ts | 2 -- .../src/components/AppstoreSidebar/AppDetailsTab.vue | 12 ------------ openapi.json | 10 +--------- 5 files changed, 4 insertions(+), 39 deletions(-) diff --git a/apps/appstore/lib/Controller/ApiController.php b/apps/appstore/lib/Controller/ApiController.php index f6e7156ff2f74..fb91cf04e116e 100644 --- a/apps/appstore/lib/Controller/ApiController.php +++ b/apps/appstore/lib/Controller/ApiController.php @@ -83,7 +83,7 @@ public function listCategories(): DataResponse { * Get all available apps * * @param bool $details - Whether to include detailed appstore information about the app - * @return DataResponse, internal: bool, isCompatible: bool, missingDependencies?: list, missingMaxNextcloudVersion: bool, missingMinNextcloudVersion: bool, ...}>, array{}> + * @return DataResponse, internal: bool, isCompatible: bool, missingDependencies?: list, ...}>, array{}> * * 200: The apps were found successfully */ @@ -132,9 +132,6 @@ public function listApps(bool $details = false): DataResponse { $ignoreMax = in_array($appData['id'], $ignoreMaxApps); $missing = $this->dependencyAnalyzer->analyze($appData, $ignoreMax); $appData['missingDependencies'] = $missing; - - $appData['missingMinNextcloudVersion'] = !isset($appData['dependencies']['nextcloud']['@attributes']['min-version']); - $appData['missingMaxNextcloudVersion'] = !isset($appData['dependencies']['nextcloud']['@attributes']['max-version']); $appData['isCompatible'] = $this->dependencyAnalyzer->isMarkedCompatible($appData); $appData['internal'] = in_array($appData['id'], $this->appManager->getAlwaysEnabledApps()); @@ -142,7 +139,7 @@ public function listApps(bool $details = false): DataResponse { }, $apps); /** - * @var list, internal: bool, isCompatible: bool, missingDependencies?: list, missingMaxNextcloudVersion: bool, missingMinNextcloudVersion: bool, ...}> $apps + * @var list, internal: bool, isCompatible: bool, missingDependencies?: list, ...}> $apps */ usort($apps, $this->sortApps(...)); return new DataResponse($apps); @@ -474,8 +471,6 @@ private function getAppsForCategory(string $requestedCategory = ''): array { $phpDependencies ), 'level' => ($app['isFeatured'] === true) ? 200 : 100, - 'missingMaxNextcloudVersion' => false, - 'missingMinNextcloudVersion' => false, 'screenshot' => isset($app['screenshots'][0]['url']) ? 'https://usercontent.apps.nextcloud.com/' . base64_encode($app['screenshots'][0]['url']) : '', 'ratingOverall' => $app['ratingOverall'], 'ratingNumOverall' => $app['ratingNumOverall'], diff --git a/apps/appstore/openapi.json b/apps/appstore/openapi.json index 4b7d17d49a0ac..5633ed7731a0a 100644 --- a/apps/appstore/openapi.json +++ b/apps/appstore/openapi.json @@ -247,9 +247,7 @@ "name", "groups", "internal", - "isCompatible", - "missingMaxNextcloudVersion", - "missingMinNextcloudVersion" + "isCompatible" ], "properties": { "id": { @@ -275,12 +273,6 @@ "items": { "type": "string" } - }, - "missingMaxNextcloudVersion": { - "type": "boolean" - }, - "missingMinNextcloudVersion": { - "type": "boolean" } } } diff --git a/apps/appstore/src/apps.d.ts b/apps/appstore/src/apps.d.ts index 6ad395e4fe336..b645ed873076f 100644 --- a/apps/appstore/src/apps.d.ts +++ b/apps/appstore/src/apps.d.ts @@ -84,8 +84,6 @@ export interface IAppstoreAppResponse extends IAppInfoData, Partial() const store = useAppsStore() -// @ts-expect-error - missing types -const productName = getCapabilities().theming.productName as string const idLimitedToGroups = useId() const lastModified = computed(() => app.releases @@ -138,15 +135,6 @@ function authorName(xmlNode): string { - - - - - {{ t('appstore', 'This app cannot be installed because the following dependencies are not fulfilled:') }}
    diff --git a/openapi.json b/openapi.json index d8a2cc3985753..ba4ee767a4b16 100644 --- a/openapi.json +++ b/openapi.json @@ -17255,9 +17255,7 @@ "name", "groups", "internal", - "isCompatible", - "missingMaxNextcloudVersion", - "missingMinNextcloudVersion" + "isCompatible" ], "properties": { "id": { @@ -17283,12 +17281,6 @@ "items": { "type": "string" } - }, - "missingMaxNextcloudVersion": { - "type": "boolean" - }, - "missingMinNextcloudVersion": { - "type": "boolean" } } }