[Bug]: /metrics endpoint does not escape hyphens #59247
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
I set up my prometheus server to scrape the new /metrics endpoint and have found out that it doesn't like apps with hyphens in the name! I have the "hide-photos" app installed and the ingestion fails once it reaches that character:
expected equal, got "-" ("INVALID") while parsing: "nextcloud_apps_info{activity=\"6.0.0-dev.0\",admin_audit=\"1.23.0\",[...]maps=\"1.6.0\",hide-"
Steps to reproduce
- Install "hide-photos" app
- Set up Prometheus server to scrape
/metrics - View Prometheus' logs or the "Targets" page of the web UI
Expected behavior
Hyphens not breaking things!
Nextcloud Server version
33
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.4
Web server
Nginx
Database engine version
PostgreSQL
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
List of activated Apps
Nextcloud Signing status
Nextcloud Logs
Additional info
No response