phpstan fixes

Author: dg

.github/workflows/static-analysis.yml

@@ -11,11 +11,11 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@v2
-            - uses: shivammathur/setup-php@v1
+            - uses: shivammathur/setup-php@v2
               with:
                   php-version: 7.4
                   coverage: none
 
             - run: composer install --no-progress --prefer-dist
-            - run: composer phpstan
+            - run: composer phpstan -- --no-progress
               continue-on-error: true # is only informative

.travis.yml

@@ -45,7 +45,7 @@ jobs:
         -   stage: Static Analysis (informative)
             php: 7.4
             script:
-                - composer run-script phpstan
+                - composer phpstan -- --no-progress
 
 
         -   stage: Code Coverage

src/PhpGenerator/Factory.php

@@ -277,6 +277,7 @@ private function extractBody(PhpParser\NodeFinder $nodeFinder, string $originalC
 			$nodeFinder->findInstanceOf($statements, Node\Scalar\String_::class),
 			$nodeFinder->findInstanceOf($statements, Node\Scalar\EncapsedStringPart::class)
 		) as $node) {
+			/** @var Node\Scalar\String_|Node\Scalar\EncapsedStringPart $node */
 			$token = substr($body, $node->getStartFilePos() - $start, $node->getEndFilePos() - $node->getStartFilePos() + 1);
 			if (strpos($token, "\n") !== false) {
 				$quote = $node instanceof Node\Scalar\String_ ? '"' : '';
@@ -290,6 +291,7 @@ private function extractBody(PhpParser\NodeFinder $nodeFinder, string $originalC
 
 		// HEREDOC => "string"
 		foreach ($nodeFinder->findInstanceOf($statements, Node\Scalar\Encapsed::class) as $node) {
+			/** @var Node\Scalar\Encapsed $node */
 			if ($node->getAttribute('kind') === Node\Scalar\String_::KIND_HEREDOC) {
 				$replacements[] = [
 					$node->getStartFilePos(),

src/PhpGenerator/Printer.php

@@ -267,7 +267,7 @@ public function printParameters($function, PhpNamespace $namespace = null): stri
 			$params[] =
 				($promoted ? Helpers::formatDocComment((string) $promoted->getComment()) : '')
 				. ($attrs = self::printAttributes($param->getAttributes(), $namespace, true))
-				. ($promoted ? ($param->getVisibility() ?: 'public') . ' ' : '')
+				. ($promoted ? ($promoted->getVisibility() ?: 'public') . ' ' : '')
 				. ltrim($this->printType($type, $param->isNullable(), $namespace) . ' ')
 				. ($param->isReference() ? '&' : '')
 				. ($variadic ? '...' : '')