Helpers::dump() in single quotes strings escapes \ only when needed

Author: dg

src/PhpGenerator/Helpers.php

@@ -58,6 +58,9 @@ private static function _dump(& $var, $level = 0)
 			}
 			return '"' . strtr($var, $table) . '"';
 
+		} elseif (is_string($var)) {
+			return "'" . preg_replace('#\'|\\\\(?=[\'\\\\]|\z)#', '\\\\$0', $var) . "'";
+
 		} elseif (is_array($var)) {
 			$space = str_repeat("\t", $level);
 

tests/PhpGenerator/Helpers.dump().phpt

@@ -22,6 +22,8 @@ Assert::same( "''", Helpers::dump('') );
 Assert::same( "'Hello'", Helpers::dump('Hello') );
 Assert::same( "'I\xc3\xb1t\xc3\xabrn\xc3\xa2ti\xc3\xb4n\xc3\xa0liz\xc3\xa6ti\xc3\xb8n'", Helpers::dump("I\xc3\xb1t\xc3\xabrn\xc3\xa2ti\xc3\xb4n\xc3\xa0liz\xc3\xa6ti\xc3\xb8n") ); // Iñtërnâtiônàlizætiøn
 Assert::same( '"\rHello \$"', Helpers::dump("\rHello $") );
+Assert::same( "'He\\llo'", Helpers::dump('He\llo') );
+Assert::same( '\'He\ll\\\\\o \\\'wor\\\\\\\'ld\\\\\'', Helpers::dump('He\ll\\\o \'wor\\\'ld\\') );
 Assert::same( 'array()', Helpers::dump(array()) );
 
 Assert::same( "array(\$s)", Helpers::dump(array(new PhpLiteral('$s'))) );