added support for final constants

Author: dg

readme.md

@@ -87,7 +87,8 @@ We can add constants ([Constant](https://api.nette.org/3.0/Nette/PhpGenerator/Co
 
 ```php
 $class->addConstant('ID', 123)
-	->setPrivate(); // constant visiblity
+	->setProtected() // constant visiblity
+	->setFinal();
 
 $class->addProperty('items', [1, 2, 3])
 	->setPrivate() // or setVisibility('private')
@@ -103,7 +104,7 @@ $class->addProperty('list')
 It generates:
 
 ```php
-private const ID = 123;
+final protected const ID = 123;
 
 /** @var int[] */
 private static $items = [1, 2, 3];

src/PhpGenerator/Constant.php

@@ -26,6 +26,9 @@ final class Constant
 	/** @var mixed */
 	private $value;
 
+	/** @var bool */
+	private $final = false;
+
 
 	/** @return static */
 	public function setValue($val): self
@@ -39,4 +42,18 @@ public function getValue()
 	{
 		return $this->value;
 	}
+
+
+	/** @return static */
+	public function setFinal(bool $state = true): self
+	{
+		$this->final = $state;
+		return $this;
+	}
+
+
+	public function isFinal(): bool
+	{
+		return $this->final;
+	}
 }

src/PhpGenerator/Factory.php

@@ -206,6 +206,7 @@ public function fromConstantReflection(\ReflectionClassConstant $from): Constant
 				? ClassType::VISIBILITY_PRIVATE
 				: ($from->isProtected() ? ClassType::VISIBILITY_PROTECTED : ClassType::VISIBILITY_PUBLIC)
 		);
+		$const->setFinal(PHP_VERSION_ID >= 80100 ? $from->isFinal() : false);
 		$const->setComment(Helpers::unformatDocComment((string) $from->getDocComment()));
 		$const->setAttributes(self::getAttributes($from));
 		return $const;

src/PhpGenerator/Printer.php

@@ -142,7 +142,10 @@ public function printClass(ClassType $class, PhpNamespace $namespace = null): st
 
 		$consts = [];
 		foreach ($class->getConstants() as $const) {
-			$def = ($const->getVisibility() ? $const->getVisibility() . ' ' : '') . 'const ' . $const->getName() . ' = ';
+			$def = ($const->isFinal() ? 'final ' : '')
+				. ($const->getVisibility() ? $const->getVisibility() . ' ' : '')
+				. 'const ' . $const->getName() . ' = ';
+
 			$consts[] = Helpers::formatDocComment((string) $const->getComment())
 				. self::printAttributes($const->getAttributes(), $namespace)
 				. $def

tests/PhpGenerator/ClassType.phpt

@@ -36,7 +36,8 @@ $class
 	->addComment("Description of class.\nThis is example\n")
 	->addComment('@property-read Nette\Forms\Form $form')
 	->setConstants(['ROLE' => 'admin'])
-	->addConstant('ACTIVE', false);
+	->addConstant('ACTIVE', false)
+		->setFinal();
 
 Assert::false($class->isFinal());
 Assert::true($class->isAbstract());

tests/PhpGenerator/expected/ClassType.expect

@@ -12,7 +12,7 @@ abstract class Example extends ParentClass implements IExample, IOne
 	}
 
 	const ROLE = 'admin';
-	const ACTIVE = false;
+	final const ACTIVE = false;
 
 	/** Commented */
 	private const FORCE_ARRAY = Nette\Utils\Json::FORCE_ARRAY;

tests/PhpGenerator/expected/ClassType.from.81.expect

@@ -1,5 +1,7 @@
 class Class11
 {
+	final public const FOO = 10;
+
 	public Foo&Bar $foo;
 	public readonly array $ro;
 

tests/PhpGenerator/fixtures/classes.php81

@@ -6,6 +6,8 @@ namespace Abc;
 
 class Class11
 {
+	final public const FOO = 10;
+
 	public Foo&Bar $foo;
 
 	public readonly array $ro;