Factory: properties in readonly classes are not readonly

Author: dg

src/PhpGenerator/Factory.php

@@ -265,7 +265,7 @@ public function fromPropertyReflection(\ReflectionProperty $from): Property
 		$prop->setType((string) $from->getType());
 
 		$prop->setInitialized($from->hasType() && array_key_exists($prop->getName(), $defaults));
-		$prop->setReadOnly(PHP_VERSION_ID >= 80100 ? $from->isReadOnly() : false);
+		$prop->setReadOnly(PHP_VERSION_ID >= 80100 && $from->isReadOnly() && !(PHP_VERSION_ID >= 80200 && $from->getDeclaringClass()->isReadOnly()));
 		$prop->setComment(Helpers::unformatDocComment((string) $from->getDocComment()));
 		$prop->setAttributes($this->getAttributes($from));
 		return $prop;

tests/PhpGenerator/ClassType.readonly.phpt

@@ -0,0 +1,24 @@
+<?php
+
+/**
+ * @phpVersion 8.2
+ */
+
+declare(strict_types=1);
+
+use Nette\PhpGenerator\ClassType;
+use Nette\PhpGenerator\Extractor;
+use Tester\Assert;
+
+
+require __DIR__ . '/../bootstrap.php';
+require __DIR__ . '/fixtures/classes.82.php';
+
+$class = ClassType::from(new Abc\Class13);
+Assert::false($class->getProperty('foo')->isReadOnly());
+Assert::false($class->getMethod('__construct')->getParameter('bar')->isReadOnly());
+
+$file = (new Extractor(file_get_contents(__DIR__ . '/fixtures/classes.82.php')))->extractAll();
+$class = $file->getClasses()[Abc\Class13::class];
+Assert::false($class->getProperty('foo')->isReadOnly());
+Assert::false($class->getMethod('__construct')->getParameter('bar')->isReadOnly());

tests/PhpGenerator/expected/ClassType.from.82.expect

@@ -1,5 +1,14 @@
 readonly class Class13
 {
+	public bool $foo;
+
+
+	public function __construct(
+		public bool $bar = true,
+	) {
+	}
+
+
 	public function func(C|(X&D)|null $foo): (A&B)|null
 	{
 	}

tests/PhpGenerator/expected/Extractor.classes.82.expect

@@ -6,6 +6,15 @@ namespace Abc;
 
 readonly class Class13
 {
+	public bool $foo;
+
+
+	public function __construct(
+		private bool $bar = true,
+	) {
+	}
+
+
 	public function func(C|(X&D)|null $foo): (A&B)|null
 	{
 	}

tests/PhpGenerator/fixtures/classes.82.php

@@ -6,6 +6,14 @@
 
 readonly class Class13
 {
+	public bool $foo;
+
+
+	public function __construct(private bool $bar = true)
+	{
+	}
+
+
 	public function func(C|(X&D)|null $foo): (A&B)|null
 	{
 	}