Method::setParameters() & ClassType::setProperties() & setMethods() retain names in keys

Author: dg

src/PhpGenerator/ClassType.php

@@ -414,12 +414,13 @@ public function addConst($name, $value)
 	 */
 	public function setProperties(array $props)
 	{
+		$this->properties = array();
 		foreach ($props as $v) {
 			if (!$v instanceof Property) {
 				throw new Nette\InvalidArgumentException('Argument must be Nette\PhpGenerator\Property[].');
 			}
+			$this->properties[$v->getName()] = $v;
 		}
-		$this->properties = $props;
 		return $this;
 	}
 
@@ -463,12 +464,13 @@ public function addProperty($name, $value = NULL)
 	 */
 	public function setMethods(array $methods)
 	{
+		$this->methods = array();
 		foreach ($methods as $v) {
 			if (!$v instanceof Method) {
 				throw new Nette\InvalidArgumentException('Argument must be Nette\PhpGenerator\Method[].');
 			}
+			$this->methods[$v->getName()] = $v;
 		}
-		$this->methods = $methods;
 		return $this;
 	}
 

src/PhpGenerator/Method.php

@@ -156,12 +156,13 @@ public function getName()
 	 */
 	public function setParameters(array $val)
 	{
+		$this->parameters = array();
 		foreach ($val as $v) {
 			if (!$v instanceof Parameter) {
 				throw new Nette\InvalidArgumentException('Argument must be Nette\PhpGenerator\Parameter[].');
 			}
+			$this->parameters[$v->getName()] = $v;
 		}
-		$this->parameters = $val;
 		return $this;
 	}
 

tests/PhpGenerator/ClassType.phpt

@@ -65,3 +65,20 @@ $method->addParameter('res', NULL)
 		->setTypeHint('array');
 
 Assert::matchFile(__DIR__ . '/ClassType.expect', (string) $class);
+
+
+// global setters & getters
+$methods = $class->getMethods();
+Assert::count(3, $methods);
+$class->setMethods(array_values($methods));
+Assert::same($methods, $class->getMethods());
+
+$properties = $class->getProperties();
+Assert::count(3, $properties);
+$class->setProperties(array_values($properties));
+Assert::same($properties, $class->getProperties());
+
+$parameters = $method->getParameters();
+Assert::count(2, $parameters);
+$method->setParameters(array_values($parameters));
+Assert::same($parameters, $method->getParameters());