Merge pull request #218 from netlify/lint/no-shadow

Add `no-shadow` ESLint rule

Author: ehmicky

.eslintrc.js

@@ -11,7 +11,6 @@ module.exports = {
     'no-await-in-loop': 0,
     'no-magic-numbers': 0,
     'no-param-reassign': 0,
-    'no-shadow': 0,
     'fp/no-class': 0,
     'fp/no-delete': 0,
     'fp/no-let': 0,

src/deploy/hash-files.test.js

@@ -10,8 +10,8 @@ test('hashes files in a folder', async (t) => {
     filter: defaultFilter,
   })
   t.truthy(files['netlify.toml'], 'includes the netlify.toml file')
-  Object.keys(files).forEach((path) => {
-    t.truthy(path, 'each file has a path')
+  Object.keys(files).forEach((filePath) => {
+    t.truthy(filePath, 'each file has a path')
   })
   t.truthy(filesShaMap, 'filesShaMap is returned')
   Object.values(filesShaMap).forEach((fileObjArray) => {