chore: enable fp/no-loops ESLint rule (#253)

ehmicky · web-flow · commit ede907aac527 · 2020-12-20T11:26:56.000+02:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -7,7 +7,6 @@ module.exports = {
     complexity: 0,
     'max-statements': 0,
     'fp/no-let': 0,
-    'fp/no-loops': 0,
     'fp/no-mutation': 0,
     'promise/prefer-await-to-callbacks': 0,
   },
diff --git a/src/methods/index.js b/src/methods/index.js
@@ -61,6 +61,8 @@ const addAgent = function (agent, opts) {
 }
 
 const makeRequestOrRetry = async function ({ url, method, defaultHeaders, agent, requestParams, opts }) {
+  // Using a loop is simpler here
+  // eslint-disable-next-line fp/no-loops
   for (let index = 0; index <= MAX_RETRY; index++) {
     const optsA = getOpts({ method, defaultHeaders, agent, requestParams, opts })
     // eslint-disable-next-line no-await-in-loop

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,8 @@ const addAgent = function (agent, opts) {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`const makeRequestOrRetry = async function ({ url, method, defaultHeaders, agent, requestParams, opts }) {`
	`64`	`+ // Using a loop is simpler here`
	`65`	`+ // eslint-disable-next-line fp/no-loops`
`64`	`66`	`for (let index = 0; index <= MAX_RETRY; index++) {`
`65`	`67`	`const optsA = getOpts({ method, defaultHeaders, agent, requestParams, opts })`
`66`	`68`	`// eslint-disable-next-line no-await-in-loop`