Fix unix time handling

Author: bcomnes

src/index.test.js

@@ -5,7 +5,7 @@ const NetlifyAPI = require('./index')
 const body = promisify(require('body'))
 const fromString = require('from2-string')
 const { TextHTTPError } = require('micro-api-client')
-const { existy } = require('./open-api/util')
+const { existy, unixNow } = require('./open-api/util')
 
 const createServer = handler => {
   const s = http.createServer(handler)
@@ -252,11 +252,12 @@ test.serial('test rate-limiting', async t => {
   try {
     server = createServer(async (req, res) => {
       if (!existy(retryAt)) {
-        retryAt = Date.now() + randomInt(1000, 5000) //ms
+        retryAt = unixNow() + randomInt(1, 5) //ms
 
         requestRateLimit(res, retryAt)
       } else {
-        const rateLimitFinished = Date.now() >= retryAt
+        const now = unixNow()
+        const rateLimitFinished = now >= retryAt
 
         if (rateLimitFinished) {
           t.pass('The client made a request at or after the rate limit deadline')

src/open-api/index.js

@@ -7,7 +7,7 @@ const Headers = fetch.Headers
 const camelCase = require('lodash.camelcase')
 const { JSONHTTPError, TextHTTPError } = require('micro-api-client')
 const debug = require('debug')('netlify:open-api')
-const { existy, sleep } = require('./util')
+const { existy, sleep, unixNow } = require('./util')
 
 exports.methods = require('./shape-swagger')
 
@@ -132,7 +132,9 @@ exports.generateMethod = method => {
               throw new Error('Header missing reset time')
             }
             debug(`resetTime: ${resetTime}`)
-            const sleepTime = resetTime - Date.now()
+            const now = unixNow()
+            debug(`unixNow(): ${now}`)
+            const sleepTime = (resetTime - now < 0 ? 0 : resetTime - now) * 1000
             debug(`sleeping for ${sleepTime}ms`)
             await sleep(sleepTime)
           } catch (e) {

src/open-api/util.js

@@ -34,3 +34,5 @@ exports.existy = val => val != null
 
 // Async sleep.  A whole new WORLD!
 exports.sleep = ms => new Promise(resolve => setTimeout(resolve, ms))
+
+exports.unixNow = () => Math.floor(new Date() / 1000)