Remove existy helper function

Author: ehmicky

src/deploy/util.js

@@ -3,13 +3,9 @@ const path = require('path')
 const pWaitFor = require('p-wait-for')
 const flatten = require('lodash.flatten')
 
-function existy(x) {
-  return x != null
-}
-
 // Default filter when scanning for files
 exports.defaultFilter = filename => {
-  if (!existy(filename)) return false
+  if (filename == null) return false
   const n = path.basename(filename)
   switch (true) {
     case n === 'node_modules':

src/index.test.js

@@ -6,7 +6,7 @@ const body = promisify(require('body'))
 const fromString = require('from2-string')
 const { TextHTTPError } = require('micro-api-client')
 
-const { existy, unixNow } = require('./open-api/util')
+const { unixNow } = require('./open-api/util')
 
 const NetlifyAPI = require('./index')
 
@@ -254,7 +254,7 @@ test.serial('test rate-limiting', async t => {
 
   try {
     server = createServer(async (req, res) => {
-      if (!existy(retryAt)) {
+      if (retryAt == null) {
         retryAt = unixNow() + randomInt(1, 5) //ms
 
         requestRateLimit(res, retryAt)

src/open-api/index.js

@@ -10,7 +10,7 @@ const { JSONHTTPError, TextHTTPError } = require('micro-api-client')
 const debug = require('debug')('netlify:open-api')
 const isStream = require('is-stream')
 
-const { existy, sleep, unixNow } = require('./util')
+const { sleep, unixNow } = require('./util')
 
 exports.methods = require('./shape-swagger')
 
@@ -29,7 +29,7 @@ exports.generateMethod = method => {
     // Path parameters
     Object.values(method.parameters.path).forEach(param => {
       const val = params[param.name] || params[camelCase(param.name)]
-      if (existy(val)) {
+      if (val != null) {
         path = path.replace(`{${param.name}}`, val)
         debug(`replacing {${param.name}} with ${val}`)
       } else if (param.required) {
@@ -41,7 +41,7 @@ exports.generateMethod = method => {
     let qs
     Object.values(method.parameters.query).forEach(param => {
       const val = params[param.name] || params[camelCase(param.name)]
-      if (existy(val)) {
+      if (val != null) {
         if (!qs) qs = {}
         qs[param.name] = val
       } else if (param.required) {

src/open-api/util.js

@@ -30,8 +30,6 @@ exports.mergeParams = (...params) => {
   return merged
 }
 
-exports.existy = val => val != null
-
 // Async sleep.  A whole new WORLD!
 exports.sleep = ms => new Promise(resolve => setTimeout(resolve, ms))