refactor: change all login errors (#748)

Author: hyrious

src/ErrorCode.ts

@@ -26,6 +26,7 @@ export enum ErrorCode {
     UserRoomListNotEmpty, // user room list is not empty.
     UserAlreadyBinding, // user already binding
     UserPasswordIncorrect, // user password (for update) incorrect
+    UserOrPasswordIncorrect, // user or password (for login) incorrect
 
     RecordNotFound = 500000, // record info not found
 

src/v2/services/user/__tests__/email.test.ts

@@ -153,7 +153,7 @@ test(`${namespace} - user email not found in login`, async ava => {
         () => new UserEmailService(ids(), t).login(`${v4()}@test.com`, v4(), async () => ""),
         {
             instanceOf: FError,
-            message: `${Status.Failed}: ${ErrorCode.UserNotFound}`,
+            message: `${Status.Failed}: ${ErrorCode.UserOrPasswordIncorrect}`,
         },
     );
 
@@ -164,7 +164,7 @@ test(`${namespace} - user email not found in login`, async ava => {
         () => new UserEmailService(ids(), t).login(userEmailInfo.userEmail, v4(), async () => ""),
         {
             instanceOf: FError,
-            message: `${Status.Failed}: ${ErrorCode.UserNotFound}`,
+            message: `${Status.Failed}: ${ErrorCode.UserOrPasswordIncorrect}`,
         },
     );
 
@@ -182,7 +182,7 @@ test(`${namespace} - user email wrong password`, async ava => {
         () => new UserEmailService(ids(), t).login(userEmailInfo.userEmail, v4(), async () => ""),
         {
             instanceOf: FError,
-            message: `${Status.Failed}: ${ErrorCode.UserPasswordIncorrect}`,
+            message: `${Status.Failed}: ${ErrorCode.UserOrPasswordIncorrect}`,
         },
     );
 

src/v2/services/user/__tests__/phone.test.ts

@@ -157,7 +157,7 @@ test(`${namespace} - user phone not found in login`, async ava => {
         () => new UserPhoneService(ids(), t).login(randomPhoneNumber(), v4(), async () => ""),
         {
             instanceOf: FError,
-            message: `${Status.Failed}: ${ErrorCode.UserNotFound}`,
+            message: `${Status.Failed}: ${ErrorCode.UserOrPasswordIncorrect}`,
         },
     );
 
@@ -168,7 +168,7 @@ test(`${namespace} - user phone not found in login`, async ava => {
         () => new UserPhoneService(ids(), t).login(userPhoneInfo.phoneNumber, v4(), async () => ""),
         {
             instanceOf: FError,
-            message: `${Status.Failed}: ${ErrorCode.UserNotFound}`,
+            message: `${Status.Failed}: ${ErrorCode.UserOrPasswordIncorrect}`,
         },
     );
 
@@ -186,7 +186,7 @@ test(`${namespace} - user phone wrong password`, async ava => {
         () => new UserPhoneService(ids(), t).login(userPhoneInfo.phoneNumber, v4(), async () => ""),
         {
             instanceOf: FError,
-            message: `${Status.Failed}: ${ErrorCode.UserPasswordIncorrect}`,
+            message: `${Status.Failed}: ${ErrorCode.UserOrPasswordIncorrect}`,
         },
     );
 

src/v2/services/user/email.ts

@@ -165,7 +165,7 @@ export class UserEmailService {
         const userUUIDByEmail = await this.userUUIDByEmail(email);
         if (!userUUIDByEmail) {
             this.logger.info("login email not found", { userEmail: { email } });
-            throw new FError(ErrorCode.UserNotFound);
+            throw new FError(ErrorCode.UserOrPasswordIncorrect);
         }
 
         const user = await userDAO.findOne(
@@ -177,21 +177,21 @@ export class UserEmailService {
             this.logger.info("login email not found user", {
                 userEmail: { email, userUUIDByEmail },
             });
-            throw new FError(ErrorCode.UserNotFound);
+            throw new FError(ErrorCode.UserOrPasswordIncorrect);
         }
 
         if (!user.user_password) {
             this.logger.info("login email user password is null", {
                 userEmail: { email, userUUIDByEmail },
             });
-            throw new FError(ErrorCode.UserNotFound);
+            throw new FError(ErrorCode.UserOrPasswordIncorrect);
         }
 
         if (user.user_password !== password) {
             this.logger.info("login email password incorrect", {
                 userEmail: { email, userUUIDByEmail },
             });
-            throw new FError(ErrorCode.UserPasswordIncorrect);
+            throw new FError(ErrorCode.UserOrPasswordIncorrect);
         }
 
         return {

src/v2/services/user/phone.ts

@@ -164,7 +164,7 @@ export class UserPhoneService {
         const userUUIDByPhone = await this.userUUIDByPhone(phone);
         if (!userUUIDByPhone) {
             this.logger.info("login phone not found", { userPhone: { phone } });
-            throw new FError(ErrorCode.UserNotFound);
+            throw new FError(ErrorCode.UserOrPasswordIncorrect);
         }
 
         const user = await userDAO.findOne(
@@ -176,22 +176,22 @@ export class UserPhoneService {
             this.logger.info("login phone not found user", {
                 userPhone: { phone, userUUIDByPhone },
             });
-            throw new FError(ErrorCode.UserNotFound);
+            throw new FError(ErrorCode.UserOrPasswordIncorrect);
         }
 
         // User didn't set password, in this case we should not allow login with password
         if (!user.user_password) {
             this.logger.info("login phone user password is null", {
                 userPhone: { phone, userUUIDByPhone },
             });
-            throw new FError(ErrorCode.UserNotFound);
+            throw new FError(ErrorCode.UserOrPasswordIncorrect);
         }
 
         if (user.user_password !== password) {
             this.logger.info("login phone user password incorrect", {
                 userPhone: { phone, userUUIDByPhone },
             });
-            throw new FError(ErrorCode.UserPasswordIncorrect);
+            throw new FError(ErrorCode.UserOrPasswordIncorrect);
         }
 
         return {