Move regression test 681 to sli2py_ignore #3664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessica-mitchell
added
the
focus
Contributor
Author
|
@heplesser There is a note in the SLI test: is this test then necessary to port? |
Contributor
|
@jessica-mitchell This test really does not contribute anything not tested elsewhere and only checks that simulations run, not their results, so we can remove this test without replacement. Move to the sli2py_ignore subdirectory. |
jessica-mitchell
changed the title
Contributor
Author
|
Ok based on comment from @heplesser I am merging this PR without reviewer, no Pytest was created only moving the SLI test to ignore folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted with AI