Fix version selector in responsive design #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Stefano Ottolenghi <stefano.ottolenghi@neo4j.com>
stefano-ottolenghi
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the nav is hidden by default at narrow page widths, you can view the nav by clicking an icon.
When the nav is opened and visible you can click links in the nav to move between pages.
However, the
onClickevents for the version selector do not work. I traced this to another event that was taking priority, which was that any click anywhere in the html triggered the nav to close. Anywhere except links to other pages, which always fire first.This PR modifies the showNav function so that the nav is hidden if you click outside the nav, but not in the nav. This means that the version selector can be used.
Note that depending on the screen resolution it is not actually possible to click outside the nav, because the nav fills the display area.