Merge pull request #172 from NativeScript/iiivanov/stop-tns-process-on-extension-deactivation

Stop tns process on extension deactivation

Author: ivanovit

package.json

@@ -27,7 +27,6 @@
   "dependencies": {
     "node-ipc": "8.10.3",
     "source-map": "0.6.1",
-    "tree-kill": "^1.2.0",
     "universal-analytics": "0.4.13",
     "vscode-chrome-debug-core": "~3.9.0",
     "vscode-debugadapter": "1.26.0",

src/common/utilities.ts

@@ -10,6 +10,7 @@ import * as fs from 'fs';
 import * as url from 'url';
 import * as path from 'path';
 import {Version} from './version';
+import {ChildProcess, exec} from 'child_process';
 
 export const enum Platform {
     Windows, OSX, Linux
@@ -380,4 +381,16 @@ export function getInstalledExtensionVersion(): Version {
 
 export function getMinSupportedCliVersion(): Version {
     return Version.parse(require('../../package.json').minNativescriptCliVersion);
+}
+
+export function killProcess(childProcess: ChildProcess) : void {
+    switch (process.platform) {
+        case "win32":
+            exec(`taskkill /pid ${childProcess.pid} /T /F`);
+            break;
+
+        default:
+            childProcess.kill("SIGINT");
+            break;
+    }
 }

src/debug-adapter/webKitDebugAdapter.ts

@@ -16,7 +16,6 @@ import {formatConsoleMessage} from './consoleHelper';
 import {Services} from '../services/debugAdapterServices';
 import {LoggerHandler, Handlers, Tags} from '../common/logger';
 import {DebugRequest} from './debugRequest';
-import * as kill from 'tree-kill';
 
 interface IScopeVarHandle {
     objectId: string;
@@ -361,7 +360,7 @@ export class WebKitDebugAdapter implements DebugProtocol.IDebugAdapter {
     public disconnect(): Promise<void> {
         this.clearEverything();
         if (this._tnsProcess) {
-            kill(this._tnsProcess.pid, 'SIGQUIT')
+            utils.killProcess(this._tnsProcess);
             this._tnsProcess = null;
         }
         if (this._webKitConnection) {

src/main.ts

@@ -4,6 +4,7 @@ import {Services} from './services/extensionHostServices';
 import {Project} from './project/project';
 import {IosProject} from './project/iosProject';
 import {AndroidProject} from './project/androidProject';
+import * as utils from './common/utilities';
 
 // this method is called when the extension is activated
 export function activate(context: vscode.ExtensionContext) {
@@ -56,6 +57,10 @@ export function activate(context: vscode.ExtensionContext) {
         tnsProcess.on('close', exitCode => {
             runChannel.hide();
         });
+
+        context.subscriptions.push({
+            dispose: () => utils.killProcess(tnsProcess)
+        });
     };
 
     let runIosCommand = vscode.commands.registerCommand('nativescript.runIos', () => {