[CI/CD] Fixing build system and improving linting #205
Conversation
Remove Windows.Storage and Storage.Streams These are deprecated.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
josesimoes
left a comment
josesimoes
left a comment
There was a problem hiding this comment.
Thanks! Let's keep this on hold until they are removed.
|
This is bringing the required work to have the pipeline running again, which is great. |
…ramework.github.io into remove-win-storage
…/nanoframework.github.io into remove-win-storage
Ellerbach
changed the title
| "MD033": false, | ||
| "MD056": true, | ||
| "MD059": false, | ||
| "MD060" : { "style": "any" } |
There was a problem hiding this comment.
This is OK with any. It's building with that on the main branch. It does help to have a coherent table style.
| msbuildArchitecture: 'x64' | ||
| maximumCpuCount: true | ||
|
|
||
| # Clean up samples folder from IoT.Device before building |
There was a problem hiding this comment.
This step can be removed. It's not doing anything.
Actually removing the samples folder on each device would cause the build to fail as the project won't be found.
| "**/TestAppv5*/**", | ||
| "**/TestMqtt*/**", | ||
| "**/Microsoft.ApplicationInsights.*/**" | ||
| "**/Microsoft.ApplicationInsights.*/**", |
There was a problem hiding this comment.
As we're removing the solution, this path won't ever exist. So this is redundant and can be removed.
Description
From initially removing Windows.Storage and Storage.Streams, to finally fixing build and improving tools
Motivation and Context
Built was failing and doc website not updating
Types of changes
Checklist: