Add return type declaration for "equals()" method (#88)

mnapoli · web-flow · commit e00b7b3d8d2e · 2019-04-23T14:00:56.000+02:00
Add return type declaration for "equals()" method
diff --git a/.travis.yml b/.travis.yml
@@ -1,11 +1,6 @@
 language: php
 
 php:
-  - 5.4
-  - 5.5
-  - 5.6
-  - 7.0
-  - 7.1
   - 7.2
   - 7.3
 
diff --git a/README.md b/README.md
@@ -38,8 +38,6 @@ class Action extends Enum
 }
 ```
 
-Note the `private` keyword requires PHP 7.1 or higher, you can omit it on PHP 7.0.
-
 ## Usage
 
 ```php
diff --git a/composer.json b/composer.json
@@ -22,7 +22,7 @@
         }
     },
     "require": {
-        "php": ">=5.4",
+        "php": ">=7.2",
         "ext-json": "*"
     },
     "require-dev": {
diff --git a/src/Enum.php b/src/Enum.php
@@ -87,7 +87,7 @@ public function __toString()
      *
      * @return bool
      */
-    final public function equals($variable = null)
+    final public function equals($variable = null): bool
     {
         return $variable instanceof self
             && $this->getValue() === $variable->getValue()

-Original file line number
+Diff line change
@@ @@ -1,11 +1,6 @@ @@
 language: php
 php:
 -  - 5.4
 -  - 5.5
 -  - 5.6
 -  - 7.0
 -  - 7.1
   - 7.2
   - 7.3
Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,6 @@ class Action extends Enum`
`38`	`38`	`}`
`39`	`39`	```
`40`	`40`
`41`		-Note the `private` keyword requires PHP 7.1 or higher, you can omit it on PHP 7.0.
`42`		`-`
`43`	`41`	`## Usage`
`44`	`42`
`45`	`43`	```php
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ public function __toString()`
`87`	`87`	`*`
`88`	`88`	`* @return bool`
`89`	`89`	`*/`
`90`		`- final public function equals($variable = null)`
	`90`	`+ final public function equals($variable = null): bool`
`91`	`91`	`{`
`92`	`92`	`return $variable instanceof self`
`93`	`93`	`&& $this->getValue() === $variable->getValue()`