fix: Fix issue where subclassed converters weren't accepted

Author: mwja

pyslash/__init__.py

@@ -8,4 +8,4 @@
 from .converters import convert
 from .decorators import slash, slash_cog
 
-__version__ = "1.1.0"
+__version__ = "1.1.1rc1"

pyslash/utils.py

@@ -106,7 +106,7 @@ def get_slash_command_type(annotation: Any) -> SlashCommandOptionType:
         No parameter type could be found
     """
     # If it's a converter or an optional of a converter, it will always be a string
-    if get_root_type(annotation) == commands.Converter:
+    if issubclass(get_root_type(annotation), commands.Converter):
         return SlashCommandOptionType.STRING
 
     type_ = SlashCommandOptionType.from_type(get_root_type(annotation))

setup.py

@@ -8,7 +8,7 @@
     install_requires = f.readlines()
 
 setup(name='dpyslash',
-      version='1.1.0',
+      version='1.1.1rc1',
       description='Improves slash commands for Python',
       author='starsflower',
       url='https://github.com/starsflower/discordpy-slash-commands',

tests/test.py

@@ -68,6 +68,19 @@ def func(foo: str, bar: Union[Literal[1], Literal[2, "name"]], baz: Union[comman
             "required": False,
             "choices": []
         })
+    
+    def test_optional_converter(self):
+        def func(baz: Optional[commands.Converter] = "bin"):
+            pass
+
+        kwargs, _ = get_slash_kwargs("test", "test", [], False, func)
+        self.assertEqual(kwargs["options"][0], {
+            "name": "baz",
+            "description": "No description",
+            "type": SlashCommandOptionType.STRING,
+            "required": False,
+            "choices": []
+        })
 
 
 if __name__ == "__main__":