test: add tests for record empty last value scenarios

* Adds tests for #109.

Author: mrodrig

README.md

@@ -176,10 +176,10 @@ $ npm run coverage
 
 Current Coverage is:
 ```
-Statements   : 100% ( 272/272 )
-Branches     : 100% ( 143/143 )
+Statements   : 100% ( 275/275 )
+Branches     : 100% ( 149/149 )
 Functions    : 100% ( 49/49 )
-Lines        : 100% ( 266/266 )
+Lines        : 100% ( 269/269 )
 ```
 
 ## Frequently Asked Questions (FAQ)

package.json

@@ -21,7 +21,7 @@
     "types": "./src/converter.d.ts",
     "scripts": {
         "test": "mocha test/tests.js",
-        "coverage": "istanbul cover mocha -- -R spec",
+        "coverage": "istanbul cover _mocha -- -R spec",
         "lint": "npm run lint:eslint && npm run lint:tslint",
         "lint:eslint": "eslint src bin test",
         "lint:tslint": "tslint -c tslint.json 'src/**/*.ts'"

test/config/testCsvFilesList.js

@@ -26,7 +26,8 @@ const fs = require('fs'),
         {key: 'extraLine', file: '../data/csv/extraLine.csv'},
         {key: 'noHeader', file: '../data/csv/noHeader.csv'},
         {key: 'sortedHeader', file: '../data/csv/sortedHeader.csv'},
-        {key: 'emptyFieldValues', file: '../data/csv/emptyFieldValues.csv'}
+        {key: 'emptyFieldValues', file: '../data/csv/emptyFieldValues.csv'},
+        {key: 'csvEmptyLastValue', file: '../data/csv/csvEmptyLastValue.csv'}
     ];
 
 function readCsvFile(filePath) {

test/config/testJsonFilesList.js

@@ -19,5 +19,6 @@ module.exports = {
     trimHeader: require('../data/json/trimHeader'),
     trimmedHeader: require('../data/json/trimmedHeader'),
     specifiedKeys: require('../data/json/specifiedKeys'),
-    emptyFieldValues: require('../data/json/emptyFieldValues')
+    emptyFieldValues: require('../data/json/emptyFieldValues'),
+    csvEmptyLastValue: require('../data/json/csvEmptyLastValue')
 };

test/csv2json.js

@@ -137,6 +137,15 @@ function runTests(jsonTestData, csvTestData) {
                     done();
                 });
             });
+
+            // Test case for #109
+            it('should properly handle the cases involving an empty field value', (done) => {
+                converter.csv2json(csvTestData.csvEmptyLastValue, (err, json) => {
+                    if (err) done(err);
+                    json.should.deepEqual(jsonTestData.csvEmptyLastValue);
+                    done();
+                });
+            });
         });
 
         describe('Error Handling', () => {

test/data/csv/csvEmptyLastValue.csv

@@ -0,0 +1,4 @@
+Name,Category,On Sale,On Closeout,Outsourced,Certification Required
+Installation,Service,X,,,
+"Wireless ""Wi-Fi"" Configuration",Service,X,,X,
+New Phone Setup,Service,X,X,X,X

test/data/json/csvEmptyLastValue.json

@@ -0,0 +1,26 @@
+[
+  {
+    "Name": "Installation",
+    "Category": "Service",
+    "On Sale": "X",
+    "On Closeout": "",
+    "Outsourced": "",
+    "Certification Required": ""
+  },
+  {
+    "Name": "Wireless \"Wi-Fi\" Configuration",
+    "Category": "Service",
+    "On Sale": "X",
+    "On Closeout": "",
+    "Outsourced": "X",
+    "Certification Required": ""
+  },
+  {
+    "Name": "New Phone Setup",
+    "Category": "Service",
+    "On Sale": "X",
+    "On Closeout": "X",
+    "Outsourced": "X",
+    "Certification Required": "X"
+  }
+]

test/json2csv.js

@@ -129,6 +129,14 @@ function runTests(jsonTestData, csvTestData) {
                     done();
                 });
             });
+
+            it('should properly convert the cases involving an empty field value in the csv', (done) => {
+                converter.json2csv(jsonTestData.csvEmptyLastValue, (err, csv) => {
+                    if (err) done(err);
+                    csv.should.equal(csvTestData.csvEmptyLastValue);
+                    done();
+                });
+            });
         });
 
         describe('Error Handling', () => {