Fix #149 (#150)

* Handle invalid parsed values from JSON.parse in csv2json

Since JSON.parse "interprets" some values, such as 39e1804 which is converted to Infinity. However, this isn't desirable since we want to return as close to the original value as possible. This commit adds some minor logic to verify that JSON.parse didn't determine the value is Infinity or -Infinity before setting the value in the returned JSON. If this is the case, the value is simply returned as the same string that's contained in the CSV.

Fixes #149

* Version bump to 3.7.1

Author: mrodrig

package-lock.json

@@ -5,7 +5,7 @@
     },
     "name": "json-2-csv",
     "description": "A JSON to CSV and CSV to JSON converter that natively supports sub-documents and auto-generates the CSV heading.",
-    "version": "3.7.0",
+    "version": "3.7.1",
     "repository": {
         "type": "git",
         "url": "https://github.com/mrodrig/json-2-csv.git"

package.json

@@ -242,7 +242,7 @@ const Csv2Json = function(options) {
         let parsedJson = parseValue(fieldValue);
         // If parsedJson is anything aside from an error, then we want to use the parsed value
         // This allows us to interpret values like 'null' --> null, 'false' --> false
-        if (!utils.isError(parsedJson)) {
+        if (!utils.isError(parsedJson) && !utils.isInvalid(parsedJson)) {
             fieldValue = parsedJson;
         } else if (fieldValue === 'undefined') {
             fieldValue = undefined;

src/csv2json.js

@@ -15,6 +15,7 @@ module.exports = {
     removeEmptyFields,
     getNCharacters,
     unwind,
+    isInvalid,
 
     // underscore replacements:
     isString,
@@ -282,3 +283,12 @@ function unique(array) {
 function flatten(array) {
     return [].concat(...array);
 }
+
+/**
+ * Used to help avoid incorrect values returned by JSON.parse when converting
+ * CSV back to JSON, such as '39e1804' which JSON.parse converts to Infinity
+ */
+function isInvalid(parsedJson) {
+    return parsedJson === Infinity ||
+        parsedJson === -Infinity;
+}

src/utils.js

@@ -31,7 +31,8 @@ const fs = require('fs'),
         {key: 'csvEmptyLastValue', file: '../data/csv/csvEmptyLastValue.csv'},
         {key: 'unwind', file: '../data/csv/unwind.csv'},
         {key: 'unwindWithSpecifiedKeys', file: '../data/csv/unwindWithSpecifiedKeys.csv'},
-        {key: 'localeFormat', file: '../data/csv/localeFormat.csv'}
+        {key: 'localeFormat', file: '../data/csv/localeFormat.csv'},
+        {key: 'invalidParsedValues', file: '../data/csv/invalidParsedValues.csv'}
     ];
 
 function readCsvFile(filePath) {

test/config/testCsvFilesList.js

@@ -23,5 +23,6 @@ module.exports = {
     quotedEmptyFieldValue: require('../data/json/quotedEmptyFieldValue'),
     csvEmptyLastValue: require('../data/json/csvEmptyLastValue'),
     unwind: require('../data/json/unwind'),
-    localeFormat: require('../data/json/localeFormat')
+    localeFormat: require('../data/json/localeFormat'),
+    invalidParsedValues: require('../data/json/invalidParsedValues')
 };

test/config/testJsonFilesList.js

@@ -162,6 +162,15 @@ function runTests(jsonTestData, csvTestData) {
                     done();
                 });
             });
+
+            // Test case for #149
+            it('should properly handle invalid parsed values', (done) => {
+                converter.csv2json(csvTestData.invalidParsedValues, (err, json) => {
+                    if (err) done(err);
+                    json.should.deepEqual(jsonTestData.invalidParsedValues);
+                    done();
+                });
+            });
         });
 
         describe('Error Handling', () => {

test/csv2json.js

@@ -0,0 +1,2 @@
+code1,code2
+39e1804,-39e1804

test/data/csv/invalidParsedValues.csv

@@ -0,0 +1,6 @@
+[
+  {
+    "code1": "39e1804",
+    "code2": "-39e1804"
+  }
+]