Merge pull request #34 from litixsoft/convert_boolean

fix converting of boolean values in json-2-csv

Author: mrodrig

lib/json-2-csv.js

@@ -126,6 +126,8 @@ var convertField = function (value) {
         return options.DELIMITER.WRAP + convertData(value, _.keys(value)) + options.DELIMITER.WRAP; // Push the recursively generated CSV
     } else if (_.isNumber(value)) { // If we have a number (avoids 0 being converted to '')
         return options.DELIMITER.WRAP + value.toString() + options.DELIMITER.WRAP;
+    } else if (_.isBoolean(value)) { // If we have a boolean (avoids false being converted to '')
+        return options.DELIMITER.WRAP + value.toString() + options.DELIMITER.WRAP;
     }
     return options.DELIMITER.WRAP + (value ? value.toString() : '') + options.DELIMITER.WRAP; // Otherwise push the current value
 };

test/CSV/unQuoted/singleDocWithBoolean.csv

@@ -0,0 +1,2 @@
+name,email,country,githubUsername,human,hipster
+mrodrig,,USA,mrodrig,true,false

test/JSON/singleDocWithBoolean.json

@@ -0,0 +1,8 @@
+{
+    "name": "mrodrig",
+    "email": null,
+    "country": "USA",
+    "githubUsername": "mrodrig",
+    "human": true,
+    "hipster": false
+}

test/testCsvFilesList.json

@@ -11,6 +11,7 @@
       {"key": "regularJson", "file": "test/CSV/unQuoted/regularJson.csv"},
       {"key": "regularJsonSorted", "file": "test/CSV/unQuoted/regularJsonSorted.csv"},
       {"key": "singleDoc", "file": "test/CSV/unQuoted/singleDoc.csv"},
+      {"key": "singleDocWithBoolean", "file": "test/CSV/unQuoted/singleDocWithBoolean.csv"},
       {"key": "differentSchemas", "file": "test/CSV/unQuoted/differentSchemas.csv"}
     ]
   },

test/testJson2Csv.js

@@ -86,6 +86,16 @@ var json2csvTests = function () {
                 });
             });
 
+            it('should parse a single JSON document with Boolean to CSV', function (done) {
+                converter.json2csv(jsonTestData.singleDocWithBoolean, function (err, csv) {
+                    if (err) { throw err; }
+                    true.should.equal(_.isEqual(err, null));
+                    csv.should.equal(csvTestData.unQuoted.singleDocWithBoolean);
+                    csv.split(options.EOL).length.should.equal(3);
+                    done();
+                });
+            });
+
             it('should parse an array of JSON documents to CSV', function (done) {
                 converter.json2csv(jsonTestData.arrayValue, function (err, csv) {
                     if (err) { throw err; }

test/testJsonFilesList.js

@@ -9,6 +9,7 @@ module.exports = {
     noData: require('./JSON/noData'),
     regularJson: require('./JSON/regularJson'),
     singleDoc: require('./JSON/singleDoc'),
+    singleDocWithBoolean: require('./JSON/singleDocWithBoolean'),
     sameSchemaDifferentOrdering: require('./JSON/sameSchemaDifferentOrdering'),
     differentSchemas: require('./JSON/differentSchemas')
 };